Allow "Unknown variable" warnings to be surpressed #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the opam-0install library to solve dependencies the "Unknown variable" warnings can get in the way of other console output. This adds an optional argument which enables printing this warning (defaulting to `true`).
|
What kind of unknown variable issue are you having? Is that related to #46 ? |
|
It's adding a lot of noise to the output of |
|
In that case it's an actual bug (variables that should be taken into account are not) so I would be inclined to close this and instead to focus on fixing tarides/opam-monorepo#349 properly. Do you want to have a go at it? |
|
I mean, #46 already exists and solves this issue, just needs to get approved or revised and merged. |
|
Ah I didn't realize there was already a fix for this in progress. Happy to close this and focus on the existing fix instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the opam-0install library to solve dependencies the "Unknown variable" warnings can get in the way of other console output. This adds an optional argument which enables printing this warning (defaulting to
true).