opam-0install-cudf: Add support for the avoid-version flag #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
reviewed
Dec 1, 2021
There was a problem hiding this comment.
Would be good to add a unit-test for this (see e.g. https://github.com/ocaml-opam/opam-0install-solver/tree/master/test/diagnostics).
Should the non-cudf solver get the same update?
| let solve context pkgs = | ||
| let req = requirements ~context pkgs in | ||
| match Solver.do_solve ~closest_match:false req with | ||
| | Some sels -> Ok sels | ||
| | Some sels -> | ||
| if selection_contains_new_avoid_versions context sels then |
There was a problem hiding this comment.
This test looks backwards to me.
|
Superseded by #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #23 by calling the solver a second time with a new universe if the solution contains packages flagged with
avoid-version. This universe contains all the packages without non-already installed packages flagged withavoid-version.If the solver suceeds to get a solution without any avoid-version flagged packages then we take that, otherwise we revert to the first solution.