Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynarray test PR broke scheduled 5.0 and 5.1 workflows #503

Open
jmid opened this issue Dec 23, 2024 · 0 comments
Open

Dynarray test PR broke scheduled 5.0 and 5.1 workflows #503

jmid opened this issue Dec 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jmid
Copy link
Collaborator

jmid commented Dec 23, 2024

The Dynarray PR #463 predated our switch away from using opam in our workflows #473.

This unfortunately meant that the test for 5.2 (when Dynarray was added) - by using an opam variable in src/dynarray/dune - worked when it was implemented - but now no longer works on the 5.0 and 5.1 workflows as the looked up ocaml_version variable is non-existent.

This can be fixed, e.g., by generating a dune file, e.g., echoing "Dynarray tests disabled on <5.2.0" in the above case.

@jmid jmid added the bug Something isn't working label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant