-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not require a coloured Unicode terminal for opam-ci #6
Comments
Also it doesn't help with copy/pasting code. Ideally the success and failure symbols should just be different, even if they have different colors. I advise to pick a consistent style, e.g. all successes are in circles and errors in square boxes or something like that. |
Agreed, but the difficulty here is just finding a good Unicode symbol set that also renders on Windows. Suggestions very welcome -- the relevant code to be factored is in src/opam-ci/user.ml#L24 |
To go a bit further: I think a |
One idea could be to use a simple table instead of encoding the same information again and again on every line. So instead of:
Have something like that:
|
Also it would be nice if the columns to display should be customisable, for instance using a config file. Also maybe it's not worth showing the columns where everything is fine :-) |
Since you are already using Besides Here's a sample usage for the coloring bits. |
Could you also use other unicode for the symbols for debian, alpine etc.? I don't have any fonts that can display these letters in boxes symbols, and I imagine I am not alone. |
The current dashboard display requires an ANSI and Unicode tty due to the use of colours. This is not optimal for several reasons:
We should fallback to a more verbose rendering format in these situations instead of blasting escape codes to the screen unconditionally.
The text was updated successfully, but these errors were encountered: