-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document the custom render option #1811
base: main
Are you sure you want to change the base?
Conversation
a03f3ff
to
e465b79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s move this to a “Custom marks” section on the Marks page, like we do for “Custom transforms” on the Transforms page.
Should we also document the other public Mark methods, and add them to the Mark class TypeScript declaration? Specifically:
(I also thought about all the public fields on Mark and subclasses, such as mark.data, mark.sort, mark.initializer, etc. But I don’t really want those to be part of the public API. 🤔) |
d076ff2
to
c11ea37
Compare
7053651
to
abf9788
Compare
33df130
to
a74892a
Compare
If we do an “Extending Plot” page, maybe it should cover more than the render function?
For #1711