-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A better “label centroid” initializer? (polylabel) #1587
Comments
the centroid of the largest polygon could also lead to the point being outside the polygon. this would be the case for a crescent-moon shaped polygon. polylabel sounds great! |
We should probably call it labelCentroid, with an ellipseRatio option that defaults to 2 (?). And maybe add an anchor option so that we can align text on the left (with textAnchor: start) or on the right (with textAnchor: end). Since polylabel returns the radius, it's not expensive to add. |
this approach could also make it easier to scale labels so they fit inside of polygons, since you'll know the ellipse dimensions anyway. |
See #2087 (comment) for using this as part of a "geo" pointer option. |
Related:
|
The centroid of a geometry is sometimes outside of it, for example (but not exclusively) with a MultiPolygon such as France+Guyane. This can result in labels or interactive tips that are quite far off from the shape they identify.
A great solution is to use @mapbox/polylabel, which guarantees that the center is inside —and furthermore at an optimal position for a centered label. The dependency is less that 1kB over the wire, including tinyqueue. An alternative approach could be to add an option to Plot.centroid, to make it choose the centroid of the largest polygon when given a multipolygon. Subpar solution, but cheaper.
Prototype https://observablehq.com/@observablehq/plot-pole-of-inaccessibility-1587
The text was updated successfully, but these errors were encountered: