Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should more constant properties (e.g., textAnchor) be specifiable as channels? #174

Closed
Fil opened this issue Feb 25, 2021 · 3 comments
Closed
Labels
question Further information is needed

Comments

@Fil
Copy link
Contributor

Fil commented Feb 25, 2021

No description provided.

@mbostock mbostock added the question Further information is needed label Feb 25, 2021
@mbostock mbostock changed the title Should some of the existing constant properties (e.g., textAnchor) support being data-driven Should more constant properties (e.g., textAnchor) be specifiable as channels? Feb 27, 2021
@mbostock
Copy link
Member

My hot take on this is “no” because you can always fall back to creating marks programmatically as needed, e.g., one Plot.text for right-aligned labels and another for left-aligned labels, with the requisite transform (or filter #138) to control who gets what. My rule of thumb is that if it’s not really a visual encoding of data, meaning if it isn’t intended to communicate information (and you wouldn’t want a corresponding legend or axis) and if there’s only a few values that it could reasonably have (e.g., label orientation) then it’s nice for simplicity for the property to be a constant.

@Fil
Copy link
Contributor Author

Fil commented Feb 27, 2021

Makes sense. Then we should also close #81 (there are ways to create the labels in a different way).

@mbostock
Copy link
Member

I don’t see us taking any immediate action on this for now, so I’m going to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is needed
Projects
None yet
Development

No branches or pull requests

2 participants