-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTR 'measurement method of' (previously in AgrO) #535
Comments
So this is a shortcut relation for something like "'plan specification' and 'executed by' some (assay and 'has specified input' some 'generically dependent continuant') "? I think if you are going to label it "measurement method of" then it would be great to reference a measurement process - probably an "assay" in the definition? |
"'plan specification' and 'executed by' some ( 'planned process' is sufficient IMO, where assay (subclass of 'planned process') requires some 'objective to produce information' which is just forces a grouping of classes.
By this logic, it would be ideal to setup/use this relation only with a dosdp pattern, so that it forces a use of a 'plan specification' and 'planned process' with a 'specifically dependent continuant'. |
What remains to be done here? |
If there aren't any issues from @ddooley or from one of the other RO experts, I think this term can be moved with the added definition. In which case, I can make a PR? |
Feel free! RO = community resource :) |
I do find the definition insufficient because it doesn't include the concept/semantics of measurement that the label "measurement method of" states. On what basis are specifically dependent continuants being grouped? One way to define this better would be to say 'measurement method of' has domain 'measurement protocol'. And then for 'measurement protocol' an axiom 'executed by' some 'measurement process' (although at moment 'executed by' is just a COB relation). |
Can an example be spelled out too: an "area measurement protocol" is a 'measurement method of' some area". Is that right? |
Is this now a change request rather than a new term request? |
I have difficulty understanding the proposed definition. What does "groups the specifically dependent continuant(s)" mean? Can examples be provided that illustrate the intent of the proposed relation? |
@KrishnaTO I am unsure what you mean by
in
Your proposed label includes the word 'measurement'. So, you are saying that the output is a measurement datum? If so, the range of the relation would be |
@KrishnaTO @ddooley Also, RO doesn't include the class I'm not a fan of |
@wdduncan OBI has been asked to critique this term/definition which we did yesterday. I forgot to mention above that this issue is about moving the AgroO relation to RO. The requested relation appears always to attach between a "measurement protocol" and a characteristic. Its a shortcut for having a protocol as part of a plan specification executed by a measurement process that is measuring some characteristic. I think COB would want to take on the "planned process" executes some "plan specification" axiom BECAUSE its in the definition of planned process?! I suggest starting from the most wordy version of the relation, and work back from there if smoother language can be accommodated, so, rather than "measurement method of" how about: label: measurement protocol of characteristic I'm not sure we need to create a "measurement process" per se. since there is "assay", (but I see that measurement process is a bit more generic language). |
Thanks @ddooley
Do you have a specific example of usage you can share? Also, part of what I don't like about the executes relation, is that linguistically we often speak of machines/people/agents executing plans. The process is what happens as a results of the agent carrying out the instructions. But, with the executes relation, it is the process that does the executing, not the agent. Anyway, that is topic for a different issue ... |
This is also AgrO's intended use, from my perspective (much to my unfortunate attempts to muddle the definitions before).
Need to involve @marieALaporte and/or @celineaubert for acceptance of label change into AgrO.
The addition of the intermediate
whereas currently, it is:
|
That last 'area measurement protocol' sentence is fine, we'd just be looking at a relabeling of the relation (if one accepts my opinion that method sounds too much like process rather than protocol):
Lets just assume "assay" for now, not add "measurement process". The "equivalent to" has to have the same kind of entity on both sides, so:
can't be right - a protocol is not a process. A protocol is part of a plan specification which is executed by a process like an assay. |
@KrishnaTO So, far I am only seeing very general examples about how some hypothetical measurement protocol is related to some hypothetical group of characteristics. It would be great if you had a specific experiment (i.e., use case) that you could provide as an example. This would be a great help (to me at least). Are saying that the protocol is about some measurement process that measured one or more characteristics. In OWL, it would be something like this:
Or do you mean the protocol is about the characteristics? For example:
An example of usage would help make this clear. |
@wdduncan That first screenshot I gave above shows the examples taken directly from AGRO. As I understand it the way you link characteristics to a process is by way of recently introduced "regulates characteristic" rather than 'has input' some characteristic. The process changes characteristics of an input, rather than taking in characteristics as input directly. So this "[protocol] 'measurement method of' some [characteristic]" just enumerates all the protocols that can measure something. One might argue that the main interest is in enumerating all the processes that can measure some quality (with each process having a plan specification that mentions a protocol). But if one is detailing protocols, and just having general names for the process, I get why this relationship is desired. |
@ddooley Thanks for pointing me to the AgrO screen shots :) Using the mulch thickness example, here is a made-up example about mulch thickness using instances (it would be nice to have a real-world example).
And another made-up example about about an instance of a mulch thickness protocol:
Here is the part I'm seeking clarity about. I assume that Option 1: Using an anonymous measurement datum:
Option 2: The protocol is about the measurement process:
Option 1 makes more sense to me. But, I might not be understanding the intent of how the protocol relates to the characteristic. Also, note that the axiom |
The |
@wdduncan I like # 1. Side note, OBI has your ":mp :has-participant :mulch-thickness-protocol" structured as ":mp executes (':plan specification' and 'has part' :mulch-thickness-protocol)" "regulates characteristic" doesn't apply to measurement processes for domain. I meant that only as an aside about existing way for some processes to "note" the characteristics of materials they change. A heating water process affects the temperature characteristic (of water). I think the use of having a list of protocols connected to the characteristics they (through measurement processes) generate datums on shows up where one has a choice of how to measure something, e.g.
|
I was not aware that the
So do I :)
How does that sound? Some possible labels for
What labels do you suggest? |
@wdduncan Oh brother- I overstepped. I forgot "executes" is coming from COB which is as you say coming from STATO. Yes, your defn. sounds fine! Names names names. |
@ddooley yes names are a pain :( Does Also, if we want domain/range constraints, we would need to |
"protocol about measurement of characteristic" sounds fine to me. @KrishnaTO ? Can't speak for RO, but I'd think given how core the process model is, that they'd be welcome. |
One last suggestion (hopefully). I think it may be advantageous to generalize the relation to:
This still satisfies the use case, but will also allow for other things that may be about the "measurement of characteristic" |
Great! |
@KrishnaTO @ddooley Please the definition I created for
Is this what you are wanting? I also have a very similar term named
From what I recall, |
I think I understand the motivation behind this request, and agree that it's important to get it sorted out. I'm working on a proposal to more clearly link characteristics to the processes that measure them: https://github.com/jamesaoverton/qqv. I think that work is relevant to this discussion, or at least would help clarify the intent here. As an OBI developer, I think that it's more useful to talk about assays (and types of assays) than about protocols. One reason is that we have more than a thousand assay terms defined, and would not like to create a shadow hierarchy of protocols for every assay type. I'd appreciate some time to make an alternative proposal to address this use case. |
@jamesaoverton Based on the discussion so far, the request was for relating protocols to characteristics. The intervening process is mentioned in the proposed definition for
However, if they prefer to use assays instead, I can close the PR. |
No, unfortunately the latter definition creates too generic and not-in-line relation between any information content entity and a characteristic, but this relation is focused on the protocols. This brings up a good discussion on whether the domain can be generalised from protocol to information content entity, and my opinion is no since we are aiming to use
@jamesaoverton I also think that although assays have some standing, the intention here was to link, the more generalised, characteristics to protocols. I agree with you that links between assays and entities can provide more immediately practical relations, but this relation was definitely targeting more abstract characteristic measurement relations. I think a move towards the qqv model may be warranted, but these legacy relations will also help to frame explicit relations between entity-characteristics. |
In AgrO, you can create a more specific |
Appreciating all the discussion on this. In line with what Bill is saying, as a design principle, a specifically named relationship P between two entity kinds X and Y is only needed to eliminate ambiguity if there is some other relation that can exist between X and Y, e.g. situation where x1 has child y1 and x1 has friend y1. Otherwise one can try to make the label as general as can be, and thus allow it to fit other similar situations and achieve the goal of keeping a language's number of object properties to a minimum. That said, Bill and I discussed this yesterday and came up with this diagram that shows the problem space, along with a few possible new "property chain" (i.e. shortcut) relations to choose from:
|
Two clarification questions for @KrishnaTO:
|
@jamesaoverton about 1 I think assay works for AGRO use case. Bill noted that assay has only material entity for input. If we wanted to measure characteristics for other kinds of input like processes, then we couldn't use assay. Hence a more general "measurement process" would be needed.
|
@jamesaoverton Instead of "senses" perhaps "measures"? But then I look at the long list of assays and think they are doing more than measuring a characteristic. The sequencing ones seem to "represent" a characteristic? Defn. molecular sequencing: "An assay the uses chemical or biochemical means to infer the sequence of a biomaterial". (This sense of characteristic seems a bit odd to me tho, its a compendium of measures of each molecular position. Invites a distinction between "primitive" characteristics and structured ones.) |
This is an attractive option for AgrO, in order to keep work down, but still keep RO relations.
If AgrO goes ahead with this model, it would definitely create a nice linkage between processes and protocols.
There was a recent release where the property was removed to satisfy the OBO dashboard requirements of using RO properties only. It is present in last month's release, found here with the mentioned PURL: https://github.com/AgriculturalSemantics/agro/releases/tag/v2022-10-18
Well, AgrO did create a sibling under |
@KrishnaTO I apologize for getting off topic, but OBO terms should never just be deleted. If http://purl.obolibrary.org/obo/AGRO_00000253 was published, you can mark it as obsolete, but it should still be included in the OWL file so that PURL can resolve. This is how we support legacy data. If you define non-RO relations, the OBO Dashboard will have a blue "i". That's still a pass. If all those non-RO relations are obsolete, you should get a green check. None of the Dashboard checks are meant to encourage terms to be deleted. |
I was thinking that senses/measures would be in AgrO specific relation. RO would only house the more general
Not trying to pressure you, but have had time work on this? It would be good if this issue can be closed soon. |
I don't think this issue is close to resolution. AgrO had a term that was doing what they wanted. They deleted it, apparently because of a miscommunication about what the OBO Dashboard check for Principle 7 means. If a new term is going to go into RO and be reused by a wider range of ontologies, then it should fit existing modelling for the affected ontologies, including OBI and IAO. The proposed PR also imports a sizeable chunk of IAO into RO for the first time. IAO already imports RO, creating a circularity that I'm concerned about. We discussed this issue for 30 minutes on the OBI call last week. I am not the only person with concerns about it. I'm just the one who is taking the time to lay out the problems. |
Senses/measures wouldn't be AGRO specific. Its very general, applying to any process generating measurement datums about characteristics. @jamesaoverton do you agree? I'd love if you suggested a name for this. Crucially, AGRO may no longer need "measurement method of" or "is about measurement characteristic of" if we get this senses/measures relation added. AGRO is in a position to structure their database as protocol -> measurement process -> senses/measures characteristic, so they'd add some general measurement processes to group protocols by and make for easier querying. Is that right @KrishnaTO ? |
It would definitely improve the querying and encase the generalised protocols for the varied methods, IMO. |
@jamesaoverton I proposed on IAO issue tracker to move @KrishnaTO @ddooley This ticket has been open for nearly a year. I would be great if you could meet with @jamesaoverton (and whoever else has concerns about this ticket) to reach a resolution. I have heard complaints from others that getting relations into RO takes too long and is too hard. If the resolution is to close this issue, I am fine with that. My involvement on this issue is mainly to help move RO along in a more efficient manner. There also seems to be a larger underlying issue of whether RO should house every relation in the Foundry. But, that is something better discussed in a separate issue (or on a call). |
Lets close this in favour of #658 (I don't have permissions to close it). |
I closed the associated PR. |
Hello,
I'd like to request adding
measurement method of
to RO along with the following details:Label
: measurement method ofDefinition
: A relation between a plan specification and a 'specifically dependent continuant', in which the plan specification groups the specifically dependent continuant(s).Uses
: area measurement protocol, material area density mesurement protocol, pivot lenght measurement protocol, etcORCID
: https://orcid.org/0000-0002-8461-9745Can be a discussion if domains and ranges are needed.
plan specification
specifically dependent continuant
Originally a question in issue #505
@marieALaporte
The text was updated successfully, but these errors were encountered: