-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFO_0000070 ("s depends on") obsolete? Replace with RO:0002502? #26
Comments
Good catch! I do not like this relation in general for EQ. We will go through this tomorrow during the face2face. |
I'm not sure about RO:depends_on. s-depends-on will be in the new BFO. It is a superProperty of BFO:inheres_in, so that may be a better replacement. Can you share examples of where it's used? |
acetylcholinesterase inhibitor hypersensitive (WBPhenotype:0000500) 'has part' some
alae absent (WBPhenotype:0001228) 'has part' some
'has part' some
'has part' some
'has part' some
'has part' some 220 uses overall in WBPhenotype |
Looking through this, I think the 'BFO70' relation mostly does the job that 'towards' is currently doing for EQ patterns. By default, I would say, replace the relation by 'towards' (RO_0002503), and you would be mostly fine (note I am not saying that using towards is a GOOD choice for the definition, I just think it is what was intended by @cmungall ). However, occasionally (see below), it is better to use inheres in, in particular when there is no other affected entity in the definition. I think we still need more fundamental discussions of what to do with qualities such as 'lacks all parts of type': Is this a relational quality that indicates that something lacks all parts of type something else (then we would need to add an inheres in clause wherever there is a lonely towards/BFO70 clause), of is it something akin to absent -> with the thing that is missing being the primary entity. Does the below make sense @dosumis
--> Here it seems to be that 'towards' (RO_0002503) should have been used.
--> Should be inheres in?
inheres in.
towards
inheres in
towards |
There are several axioms using BFO_0000070 which has no data associated with it. From what I can find, namely this BFO GitHub page:
https://github.com/BFO-ontology/BFO/blob/master/releases/owl-ruttenberg-2010-05-25/bfo-relations.lisp
BFO_0000070 looks like it was at some point "s depends on"
Maybe (although I can't yet find documentation on it) the RO term "depends on" RO:0002502 has replaced it?
The text was updated successfully, but these errors were encountered: