-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide binary #9
Comments
To be honest I never thought that someone will use this as an application instead of other tftp servers such as atftp. Do you prefer it because it can be easily build into a single binary? Or is there any other reason? |
All (or most) else being equal, I would prefer to use networking applications written in rust for the reliability and security. In the past I used a fork of |
Hm cool. Yes I'm willing to accept your PR. |
I'm not sure about the binary names, but we can decide later. |
I was about to open a pull request to add a simple binary when reading cargo docs I spotted it's possible to run the included examples as binaries with cargo: $ cargo run --example tftpd-dir
TFTP directory: ...
Listening on: 0.0.0.0:6969
^C
$ cargo run --example tftpd-targz <archive-path>
Listening on: 0.0.0.0:6969
^C Hopefully they are adequate for you @alexmaco - if you think more is needed let me know and I'll spin up a branch with the binary I started on and we can work on it together. |
For convenient use, providing an executable binary (available via
cargo install async-tftp-rs
for instance) from this crate would be great. This would make it immediately useful for most use cases that just want to serve tftp, and are not looking to embed tftp in a larger application.I think this crate would work great as an application since it implements most of the TFTP-related RFCs.
BIkeshedding topics:
tftp-server
, orserve-tftp
, to reserve space for a futuretftp-client
I'm willing to add the binary wrapper implementation and make a PR if you're willing to merge it.
The text was updated successfully, but these errors were encountered: