-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unsatisfiability from COB interaction #1612
Comments
Slides from COB workshop: https://docs.google.com/presentation/d/1UhWNyZI6_4tc-xR2NXNAIaqBTDgOYLYCAG7emrkGmKY/edit#slide=id.gef3aeb5791_0_630 relevant issue: OBOFoundry/COB#52 |
Also want to note this isn't the only unsatisfiable OBI term in Ubergraph, just the only one I've output an explanation for. There are 98; it could be many of them are the same issue. |
looks like this is still an issue? |
Discussed on the OBI call 2023-03-06: OBI would like to follow COB, and so we can put 'region' under 'material entity'. It would be better for SO to clean up their definitions, but that's their problem. OBI has created two subclasses of 'region':
For now at least we will leave these as subclasses of 'region'. We may need to fix that later. |
Update: COB hasn't made commitment to including "region" and some other SO terms yet (ME or ICE discussion). May be discussed in 22/23 Sept 2024 discussion. |
COB has absolutely made the commitment, see https://github.com/OBOFoundry/COB/blob/master/src/ontology/components/cob-to-external.tsv SO sf (and this region) are material entities For full context see the slides from the 2021 workshop where this was agreed on: |
the fix here is to change the OBI SO injection to be consistent with COB (this will be fixed when COB imports work smoothly but for now COB should be taken as SOT and we should align with it as far as possible) |
That change to COB hasn't yet been released, but we'll try to get a new COB release soon. Our OBI-to-COB transition PRs do now put 'region' under 'material entity'. |
I'm trying to resolve unsatisfiable classes found in the Ubergraph build. This issue overlaps OBI, SO, and COB.
genotyping assay EquivalentTo Nothing
(region and (is concretized as some (characteristic_of some
(nucleic acid and (part_of some organism)))))
The core problem is that OBI is using region as a generically dependent continuant, but COB is asserting it to be a subclass of material entity. Who should change, OBI or COB? Could OBI change the axiom to something like:
(nucleic acid and (part_of some organism)))
The text was updated successfully, but these errors were encountered: