Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsatisfiability from COB interaction #1612

Open
balhoff opened this issue Oct 12, 2022 · 8 comments
Open

unsatisfiability from COB interaction #1612

balhoff opened this issue Oct 12, 2022 · 8 comments
Assignees
Labels
coord:COB migration coord:OBO coordination coordinating between OBI and other OBOF ontolgies

Comments

@balhoff
Copy link

balhoff commented Oct 12, 2022

I'm trying to resolve unsatisfiable classes found in the Ubergraph build. This issue overlaps OBI, SO, and COB.

genotyping assay EquivalentTo Nothing

The core problem is that OBI is using region as a generically dependent continuant, but COB is asserting it to be a subclass of material entity. Who should change, OBI or COB? Could OBI change the axiom to something like:

@cmungall
Copy link
Contributor

cmungall commented Oct 12, 2022

Slides from COB workshop: https://docs.google.com/presentation/d/1UhWNyZI6_4tc-xR2NXNAIaqBTDgOYLYCAG7emrkGmKY/edit#slide=id.gef3aeb5791_0_630

relevant issue: OBOFoundry/COB#52

@balhoff
Copy link
Author

balhoff commented Oct 12, 2022

Also want to note this isn't the only unsatisfiable OBI term in Ubergraph, just the only one I've output an explanation for. There are 98; it could be many of them are the same issue.

@cmungall
Copy link
Contributor

cmungall commented Mar 1, 2023

looks like this is still an issue?

@jamesaoverton
Copy link
Contributor

Discussed on the OBI call 2023-03-06: OBI would like to follow COB, and so we can put 'region' under 'material entity'. It would be better for SO to clean up their definitions, but that's their problem.

OBI has created two subclasses of 'region':

For now at least we will leave these as subclasses of 'region'. We may need to fix that later.

@hectorguzor hectorguzor added coord:COB migration coord:OBO coordination coordinating between OBI and other OBOF ontolgies labels Apr 17, 2023
@ddooley
Copy link
Contributor

ddooley commented Sep 9, 2024

Update: COB hasn't made commitment to including "region" and some other SO terms yet (ME or ICE discussion). May be discussed in 22/23 Sept 2024 discussion.

@cmungall
Copy link
Contributor

cmungall commented Sep 9, 2024

COB has absolutely made the commitment, see

https://github.com/OBOFoundry/COB/blob/master/src/ontology/components/cob-to-external.tsv

SO sf (and this region) are material entities

For full context see the slides from the 2021 workshop where this was agreed on:

https://docs.google.com/presentation/d/1UhWNyZI6_4tc-xR2NXNAIaqBTDgOYLYCAG7emrkGmKY/edit#slide=id.gef3aeb5791_0_572

@cmungall
Copy link
Contributor

cmungall commented Sep 9, 2024

the fix here is to change the OBI SO injection to be consistent with COB (this will be fixed when COB imports work smoothly but for now COB should be taken as SOT and we should align with it as far as possible)

@jamesaoverton
Copy link
Contributor

That change to COB hasn't yet been released, but we'll try to get a new COB release soon. Our OBI-to-COB transition PRs do now put 'region' under 'material entity'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coord:COB migration coord:OBO coordination coordinating between OBI and other OBOF ontolgies
Projects
None yet
Development

No branches or pull requests

5 participants