Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope #49

Closed
ghost opened this issue Mar 21, 2014 · 14 comments
Closed

Scope #49

ghost opened this issue Mar 21, 2014 · 14 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Mar 21, 2014

Add use scope

@thomseddon
Copy link
Member

Good shout, +1

@mjsalinger
Copy link
Contributor

+1 on this

@toddpi314
Copy link

+1

3 similar comments
@ghost
Copy link
Author

ghost commented Jun 30, 2014

+1

@ftrianakast
Copy link

+1

@Webdesignwill
Copy link

+1

@cadecairos
Copy link

I'd love to see this get implemented, I'll even do the work for you!

@thomseddon Is there a specific way you'd like this to get implemented?

@jamiemccrindle
Copy link

+1

2 similar comments
@jasonfutch
Copy link

+1

@JFKingsley
Copy link

+1

@thomseddon
Copy link
Member

Happy to accept a PR on this, this could either be an extra param on things like getAccessToken or with a specific model function checkScope....also happy to discuss more before PR :)

@thomseddon thomseddon modified the milestones: 2.4.0, 3.0.0 Jan 26, 2015
@mjsalinger mjsalinger self-assigned this Jan 27, 2015
@mjsalinger
Copy link
Contributor

Thoughts on implementation -

  • An additional (optional) callback function in authCodeGrant validateScope, which passes the scope from the request and returns the user-granted scope.
  • If scope is included as part of the authCodeGrant request, the results of validateScopeScope are saved along with the auth grant.
  • When requesting a token, scope can be validated via a model definition 'getScope'
  • The granted scope is returned in the access token response if it was included anywhere in the request chain

@lfk
Copy link
Member

lfk commented Jan 29, 2015

Submitted PR #149 for review.

@mjsalinger
Copy link
Contributor

Scope has been implemented in the new PR #203. Closing to clean up the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants