Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename entry_schema and key_schema to entry_type and key_type #125

Open
tliron opened this issue Jul 9, 2022 · 1 comment
Open

Rename entry_schema and key_schema to entry_type and key_type #125

tliron opened this issue Jul 9, 2022 · 1 comment

Comments

@tliron
Copy link
Contributor

tliron commented Jul 9, 2022

The word "schema" is confusing here, as we are referring to a data type.

Changing it to _type also aligns with my general preference that keynames include the name of entity type of what they refer to.

@lauwers
Copy link
Contributor

lauwers commented Jul 17, 2022

I don't believe "type" is the correct type of entity here. Let's assume we have a list of lists. In that case the "entry_schema" is "list". But since "entry_schema" is required for lists, we also need to specify the entry schema for the list type specified in the original entity schema. This means that we may need full parameter definition syntax here, in which case we should consider renaming entry_schema to entry_definition, not entry_type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants