fix(add_upgrade_boot_entry): convert arg list into a tuple #1313
Conversation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
Note that first time contributors cannot run tests automatically - they need to be started by a reviewer. It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported,
See other labels for particular jobs defined in the Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
Convert collected rd.lvm args into a tuple before trying to make a set with one of the elements being the args. As list is not hashable, this causes the actor to crash.
MichalHe
force-pushed
the
fix_undesired_cmdline_args
branch
from
a1459c9 to
c7ceb0d
Compare
|
@oamg/developers Can someone look at this and merge it if it is OK? The change needs essentially no testing. |
| @@ -273,7 +273,7 @@ def test_get_rdlvm_arg_values(monkeypatch): | |||
|
|
|||
| args = addupgradebootentry._get_rdlvm_arg_values() | |||
|
|
|||
| assert args == ['A', 'B'] | |||
| assert tuple(args) == ('A', 'B') | |||
There was a problem hiding this comment.
_get_rdlvm_arg_values should be already returning a tuple, so shouldn't you be testing:
| assert tuple(args) == ('A', 'B') | |
| assert args == ('A', 'B') |
otherwise you're asserting that the return value of _get_rdlvm_arg_values can be converted to a tuple matching (A, B)
Convert collected rd.lvm args into a tuple before trying to make a set with one of the elements being the args. As list is not hashable, this causes the actor to crash.