Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] IPU: Firewalld actors for el9 to el10 #1303

Closed
wants to merge 5 commits into from
Closed

Conversation

erig0
Copy link
Contributor

@erig0 erig0 commented Oct 30, 2024

The main actor, FirewalldIptablesModules, will install kernel-modules-extra if it's determined that firewalld configuration depends upon iptables.

Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@erig0 erig0 force-pushed the rhel-10 branch 6 times, most recently from a70270b to 427d818 Compare October 30, 2024 19:48
@erig0
Copy link
Contributor Author

erig0 commented Oct 30, 2024

review please @oamg/developers

@erig0
Copy link
Contributor Author

erig0 commented Nov 12, 2024

Please hold off on merging this PR. We may not need these actors after all.

Ref: https://issues.redhat.com/browse/RHEL-65224

@erig0 erig0 changed the title IPU: Firewalld actors for el9 to el10 [WIP] IPU: Firewalld actors for el9 to el10 Nov 12, 2024
@erig0
Copy link
Contributor Author

erig0 commented Nov 19, 2024

Closing as per above. These actors are not necessary as this issue will be handled at the RPM level.

@erig0 erig0 closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants