Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHEL 7 for SAP ELS to the RHUI config #1254

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

Rezney
Copy link
Member

@Rezney Rezney commented Jun 19, 2024

There is going to be a separate ELS RHUI client package for
RHEL 7 for SAP.

Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - master - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

There is going to be a separate ELS RHUI client package for
RHEL 7 for SAP.
@Rezney
Copy link
Member Author

Rezney commented Jun 19, 2024

@MichalHe could you please take a look? ^

Copy link
Member

@MichalHe MichalHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rezney Rezney merged commit 4ba0ec3 into oamg:master Jun 19, 2024
16 checks passed
Rezney added a commit to Rezney/leapp-repository that referenced this pull request Jun 21, 2024
This reverts commit 4ba0ec3.

It turned out this change is not needed at the end.
pirat89 pushed a commit that referenced this pull request Jun 27, 2024
This reverts commit 4ba0ec3.

It turned out this change is not needed at the end.
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Jun 27, 2024
@pirat89
Copy link
Member

pirat89 commented Jun 27, 2024

keeping out of the changelog as the PR has been reverted

yuravk pushed a commit to yuravk/leapp-repository that referenced this pull request Aug 19, 2024
There is going to be a separate ELS RHUI client package for
RHEL 7 for SAP.

(cherry picked from commit 4ba0ec3)
yuravk pushed a commit to yuravk/leapp-repository that referenced this pull request Aug 19, 2024
This reverts commit 4ba0ec3.

It turned out this change is not needed at the end.

(cherry picked from commit 82d2db8)
yuravk pushed a commit to yuravk/leapp-repository that referenced this pull request Aug 20, 2024
There is going to be a separate ELS RHUI client package for
RHEL 7 for SAP.

(cherry picked from commit 4ba0ec3)
yuravk pushed a commit to yuravk/leapp-repository that referenced this pull request Aug 20, 2024
This reverts commit 4ba0ec3.

It turned out this change is not needed at the end.

(cherry picked from commit 82d2db8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants