Upgrade kube dependency to 0.34.0 #539

messense · 2020-02-15T12:17:39Z

cargo build & cargo test passes on my local macOS.

Fixes #529

messense · 2020-02-16T04:15:22Z

The Kubernetes E2E test output isn't very helpful.

Error: timed out waiting for the condition
make: *** [kind-e2e] Error 1
Makefile:37: recipe for target 'kind-e2e' failed

wonderflow · 2020-02-17T02:07:42Z

Yeah, it's currently hard to find out the reason. In my experience, this usually means the pod of rudr can't be running. Can you try to build the image , deploy and fix it locally.

messense · 2020-02-17T02:13:43Z

Yeah, it's currently hard to find out the reason. In my experience, this usually means the pod of rudr can't be running. Can you try to build the image , deploy and fix it locally.

To be clear, this is just a drive-by PR.
I am not very familiar with k8s, and I tried but failed to start k8s with Docker Desktop on macOS.

wonderflow · 2020-02-17T02:27:12Z

I tried your PR locally, but it fails on compiling:

  Compiling bytes v0.5.4
   Compiling futures-timer v3.0.1
   Compiling proc-macro2 v1.0.8
   Compiling libc v0.2.66
   Compiling syn v1.0.14
   Compiling indexmap v1.3.2
   Compiling num-traits v0.2.11
   Compiling num-integer v0.1.42
   Compiling num-iter v0.1.40
   Compiling memchr v2.3.2
   Compiling openssl-sys v0.9.54
   Compiling unicase v2.6.0
   Compiling backtrace-sys v0.1.32
   Compiling proc-macro-nested v0.1.3
   Compiling futures-channel v0.3.4
   Compiling unicode-normalization v0.1.12
   Compiling thread_local v1.0.1
   Compiling miniz_oxide v0.3.6
   Compiling serde v1.0.104
   Compiling rustversion v1.0.2
   Compiling encoding_rs v0.8.22
   Compiling k8s-openapi v0.7.1
   Compiling textwrap v0.11.0
   Compiling humantime v1.3.0
   Compiling want v0.3.0
error: `core::slice::<impl [T]>::len` is not yet stable as a const fn
   --> /home/jianbo/.cargo/registry/src/github.com-1ecc6299db9ec823/bytes-0.5.4/src/bytes.rs:130:18
    |
130 |             len: bytes.len(),
    |                  ^^^^^^^^^^^

   Compiling aho-corasick v0.7.8
error: aborting due to previous error

error: Could not compile `bytes`.
warning: build failed, waiting for other jobs to finish...

messense · 2020-02-17T02:43:10Z

@wonderflow It requires rustc 1.41(current stable version).

wonderflow · 2020-02-17T02:57:29Z

Thanks @messense, I have successfully build and it crashes as the following errors:

root@leijuan-thinkstation-p720:/home/jianbo/rudr# kubectl logs -f rudr-764f4c5d8d-tn7sh
2020-02-17 02:56:11 INFO [rudr:src/main.rs:73] starting server
2020-02-17 02:56:11 INFO [rudr:src/main.rs:33] Loading in-cluster config
2020-02-17 02:56:11 INFO [rudr:src/main.rs:77] apiserver:https://10.96.0.1:443
2020-02-17 02:56:11 INFO [kube::api::reflector:/home/jianbo/.cargo/registry/src/github.com-1ecc6299db9ec823/kube-0.25.0/src/api/reflector.rs:107] Starting Reflector for RawApi { resource: "componentschematics", group: "core.oam.dev", namespace: Some("default"), version: "v1alpha1", prefix: "apis" }
2020-02-17 02:56:11 INFO [rudr:src/main.rs:173] Watcher is running
2020-02-17 02:56:11 INFO [rudr:src/main.rs:33] Loading in-cluster config
2020-02-17 02:56:11 INFO [rudr:src/main.rs:177] Health server is running on 0.0.0.0:8080
thread '<unnamed>' panicked at 'there is no reactor running, must be called from the context of Tokio runtime', src/libcore/option.rs:1188:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Any', src/libcore/result.rs:1188:5

messense · 2020-02-17T03:38:17Z

@wonderflow Great, I'll look into it later.

wonderflow · 2020-02-17T05:53:46Z

You could rebase the master branch and the CI will give more detail logs

messense · 2020-02-17T06:44:22Z

@wonderflow Still can't spot the problem in the detailed logs.

src/main.rs

wonderflow · 2020-02-17T08:26:52Z

Thanks so much for this great PR, but it's better if you could setup test environment.

I'm not very sure that will it possible that the health_server won't working?

messense · 2020-02-17T08:49:47Z

Kubernetes E2E test passes.

wonderflow

Thanks so much for your effort and it's great to see such big contribution.

But as you can see, this PR is really complex. I don't know if these changes are all for upgrade dependency.
Hope you could give more information about this PR and help us understand better!

Thanks again!

wonderflow · 2020-02-17T09:44:46Z

.github/workflows/rust.yml

+        uses: actions-rs/toolchain@v1
+        with:
+            toolchain: stable
+            override: true


Do you mean this is a recommend way to always use latest rust version? Will we have risk to do so?

wonderflow · 2020-02-17T09:46:07Z

Dockerfile

@@ -1,4 +1,4 @@
-ARG BUILDER_IMAGE=rust:1.38
+ARG BUILDER_IMAGE=rust:1.41


please go through this repo and make sure all versions are updated to 1.41, thanks!

wonderflow · 2020-02-17T09:47:50Z

healthscope/src/main.rs

@@ -70,11 +66,12 @@ fn main() -> Result<(), Error> {
        let client = APIClient::new(cfg_watch);
        let mut cnt = 0;
        loop {
-            let req = healthscope_resource.list(&ListParams::default())?;
-            match client.request::<ObjectList<HealthScopeObject>>(req) {
+            let req = healthscope_resource.list(&ListParams::default()).unwrap();


What will happen if it's None and causes panic?

I'll let you review the over all approach before addressing these small nits.

wonderflow · 2020-02-17T09:48:52Z

healthscope/src/main.rs

        }
    });

-    let server = std::thread::spawn(move || {
+    let server1 = tokio::spawn(async move {


maybe we should rename server1 to main_server

wonderflow · 2020-02-17T09:49:10Z

healthscope/src/main.rs

    });

-    std::thread::spawn(move || {
+    let server2 = tokio::spawn(async move {


rename server2 to health_server will be better

wonderflow · 2020-02-17T09:56:11Z

src/schematic/scopes.rs

@@ -45,38 +45,38 @@ impl OAMScope {
        }
    }
    /// create will create a real scope instance
-    pub fn create(&self, owner: meta::OwnerReference) -> Result<(), Error> {
+    pub async fn create(&self, owner: meta::OwnerReference) -> Result<(), Error> {


could you give some explanation that why we must change every function(including add\modify\delete\remove\status) to async?

kube-rs needs async/await, and async is invasive, which means that async fns needs to be called in async fns.

messense · 2020-02-17T10:19:26Z

To upgrade kube-rs, we also need to upgrade reqwest to 0.10 which depends on hyper 0.13.

See https://github.com/dtolnay/async-trait for #[async_trait] usage.

wonderflow mentioned this pull request Feb 17, 2020

print pod logs when helm install timeout #540

Merged

wonderflow reviewed Feb 17, 2020

View reviewed changes

src/main.rs Show resolved Hide resolved

wonderflow reviewed Feb 17, 2020

View reviewed changes

messense added 8 commits June 11, 2020 16:28

Upgrade kube dependency to 0.25.0

3206bd0

Update CI Rust verson to latest stable

6795f51

Roughly port healthscope

94b2620

Run health server with tokio::spawn instead of thread::spawn

845aba5

Replace thread::sleep with tokio::time::delay_for

5b66000

await on Server.serve

41c4943

Upgrade to stable merge-friendly Cargo v2 lockfile format

80f32b2

WIP: Upgrade kube-rs to 0.34.0

2e5dd85

messense changed the title ~~Upgrade kube dependency to 0.25.0~~ Upgrade kube dependency to 0.34.0 Jun 13, 2020

Try to fix mock kube config

5f723b1

messense closed this Jun 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade kube dependency to 0.34.0 #539

Upgrade kube dependency to 0.34.0 #539

messense commented Feb 15, 2020 •

edited

Loading

messense commented Feb 16, 2020

wonderflow commented Feb 17, 2020 •

edited

Loading

messense commented Feb 17, 2020 •

edited

Loading

wonderflow commented Feb 17, 2020

messense commented Feb 17, 2020

wonderflow commented Feb 17, 2020

messense commented Feb 17, 2020

wonderflow commented Feb 17, 2020

messense commented Feb 17, 2020

wonderflow commented Feb 17, 2020

messense commented Feb 17, 2020

wonderflow left a comment

wonderflow Feb 17, 2020

wonderflow Feb 17, 2020

wonderflow Feb 17, 2020

messense Feb 17, 2020

wonderflow Feb 17, 2020

wonderflow Feb 17, 2020

wonderflow Feb 17, 2020

messense Feb 17, 2020

messense commented Feb 17, 2020

		@@ -1,4 +1,4 @@
		ARG BUILDER_IMAGE=rust:1.38
		ARG BUILDER_IMAGE=rust:1.41

Upgrade kube dependency to 0.34.0 #539

Upgrade kube dependency to 0.34.0 #539

Conversation

messense commented Feb 15, 2020 • edited Loading

messense commented Feb 16, 2020

wonderflow commented Feb 17, 2020 • edited Loading

messense commented Feb 17, 2020 • edited Loading

wonderflow commented Feb 17, 2020

messense commented Feb 17, 2020

wonderflow commented Feb 17, 2020

messense commented Feb 17, 2020

wonderflow commented Feb 17, 2020

messense commented Feb 17, 2020

wonderflow commented Feb 17, 2020

messense commented Feb 17, 2020

wonderflow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

messense commented Feb 17, 2020

messense commented Feb 15, 2020 •

edited

Loading

wonderflow commented Feb 17, 2020 •

edited

Loading

messense commented Feb 17, 2020 •

edited

Loading