Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build icons command doesn't work for linked package #218

Open
Joozty opened this issue Jul 16, 2020 · 0 comments
Open

build icons command doesn't work for linked package #218

Joozty opened this issue Jul 16, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@Joozty
Copy link
Member

Joozty commented Jul 16, 2020

When design package is linked in different project and the build command is triggered config file from design is not loaded. It happens because we use process.cwd() and the path refer to to that project.

/home/user/dashboard$ node ./node_modules/.bin/design build icons # process.cwd() == /home/user/dashboard

Possible solutions:

  1. use __dirname: That points correctly to the design folder but since the packages are linked it may not pick up project config if both packages are on the same level:
/home/user/design <- will pick up only config from here
/home/user/dashboard
  1. Explicitly load design config in build command and keep process.cwd() It may happen that config will be loaded twice therefore we should maybe handle it somehow.

  2. Anything else?

@Joozty Joozty added the bug Something isn't working label Jul 16, 2020
@vkot91 vkot91 pinned this issue Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant