Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image_template: enable image template version name #733

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

mmartinv
Copy link
Contributor

  • image_template: allow to setup template version name
  • image_template: allow to setup template OS and description

@mmartinv mmartinv requested a review from mnecas as a code owner November 27, 2023 13:08
@mmartinv mmartinv force-pushed the enable-image-template-version-name branch from f28453e to d8384e5 Compare November 27, 2023 13:09
@mmartinv mmartinv changed the title enable image template version name image_template: enable image template version name Nov 27, 2023
mmartinv added a commit to mmartinv/ovirt-ansible-collection that referenced this pull request Nov 27, 2023
mmartinv added a commit to mmartinv/ovirt-ansible-collection that referenced this pull request Nov 27, 2023
Signed-off-by: Miguel Martín <[email protected]>
@mmartinv mmartinv force-pushed the enable-image-template-version-name branch from 7e6569a to 40a92a0 Compare November 27, 2023 14:45
mmartinv added a commit to mmartinv/ovirt-ansible-collection that referenced this pull request Nov 27, 2023
Signed-off-by: Miguel Martín <[email protected]>
@mmartinv mmartinv force-pushed the enable-image-template-version-name branch from 40a92a0 to a45e2d9 Compare November 27, 2023 14:52
mmartinv added a commit to mmartinv/ovirt-ansible-collection that referenced this pull request Nov 29, 2023
Signed-off-by: Miguel Martín <[email protected]>
@mmartinv mmartinv force-pushed the enable-image-template-version-name branch from a45e2d9 to 5bc6921 Compare November 29, 2023 16:55
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

roles/image_template/tasks/qcow2_image.yml Outdated Show resolved Hide resolved
roles/image_template/README.md Show resolved Hide resolved
mmartinv added a commit to mmartinv/ovirt-ansible-collection that referenced this pull request Dec 11, 2023
Signed-off-by: Miguel Martín <[email protected]>
@mmartinv mmartinv force-pushed the enable-image-template-version-name branch from 5bc6921 to 67a4c86 Compare December 11, 2023 09:16
mmartinv added a commit to mmartinv/ovirt-ansible-collection that referenced this pull request Dec 11, 2023
Signed-off-by: Miguel Martín <[email protected]>
@mmartinv mmartinv force-pushed the enable-image-template-version-name branch from 67a4c86 to 8b67368 Compare December 11, 2023 13:44
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas
Copy link
Member

mnecas commented Dec 11, 2023

Posted #735 to fix the ansible-test ci

Allow to create templates with the same name but with
different version by setting up the `template_version_name`
variable. Creating a new version requires the base template
to exist. If not specified the value of the variable is
`base version` which is the default value for base templates.

Signed-off-by: Miguel Martín <[email protected]>
Allow to setup the template Operative System and the
Description.

Signed-off-by: Miguel Martín <[email protected]>
Signed-off-by: Miguel Martín <[email protected]>
@mwperina mwperina force-pushed the enable-image-template-version-name branch from 8b67368 to 25c2471 Compare December 12, 2023 08:26
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas mnecas merged commit a2a8562 into oVirt:master Dec 12, 2023
4 checks passed
mwperina added a commit that referenced this pull request Jan 30, 2024
mnecas pushed a commit that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants