Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do we still need majorVersion() on EsSearcherFactory? #104

Open
epugh opened this issue Apr 15, 2022 · 0 comments
Open

do we still need majorVersion() on EsSearcherFactory? #104

epugh opened this issue Apr 15, 2022 · 0 comments

Comments

@epugh
Copy link
Member

epugh commented Apr 15, 2022

We used to do some logic about before ES 5 and after ES 5 around the source field???

However, look at this: https://github.com/o19s/splainer-search/blob/master/factories/esSearcherFactory.js#L126

As far as I can tell, we do the same thing...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epugh