Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip out SASS #1113

Merged
merged 16 commits into from
Dec 1, 2024
Merged

Strip out SASS #1113

merged 16 commits into from
Dec 1, 2024

Conversation

epugh
Copy link
Member

@epugh epugh commented Nov 29, 2024

Description

sassc-rails and sass-rails are abandoned. Dart Sass is the future. However, digging into it, we don't actually embrace sass, everything we do is just css...

Let's remove the Sass as much as possible.

One thing is that for some reason sprockets-rails and sprockets autoloads sassc, so we can't totally remove the dependency.

Motivation and Context

How Has This Been Tested?

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

FontAwesome requires Sass, and it's a pain to use these days.   Getting rid of Font Awesome opens the door to getting rid of Sass...    Let's Kondo this dependency!
@epugh epugh changed the title sigh... back out update to see if we can get clean run. Strip out SASS Nov 30, 2024
epugh added 4 commits December 1, 2024 12:19
This reverts commit a34290e.
This reverts commit cdae586.
@epugh
Copy link
Member Author

epugh commented Dec 1, 2024

I think I am done... So, Sprockets 4 will always invoke sassc, and so if you don't have it, you get an exception. So we are stuck with that. Also, Mission Control Jobs 0.6.0 still embeds sass, and of course, it doesn't work with latest sassc, only with dartsass. And Sprockets4 doesn't support dartsass... so kind of at an impass.. I think to move forward, we need to embrace jssbundling/cssbundling, or fork sprockets 4?

@epugh epugh temporarily deployed to quepid-pr-1113 December 1, 2024 17:31 Inactive
@epugh epugh merged commit 8154e64 into main Dec 1, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant