-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce sort order for winds #51
Comments
Is this done? |
No |
Sorting can be done in Shot's post_init. |
That would be great! The process to contribute:
Then the owner (@o-murphy) can review and accept your changes. |
it shouldn't be difficult, I think it can be done in one line, but I would do it with some setter method, cause Shot dataclass ain't frozen and we have to sort winds each times it changes, not just on postinit |
In the case of multiple winds:
TrajectoryCalc
assumes thatShot.winds[]
is sorted byWind.until_distance
(ascending). However right now we do not enforce that or even check whether that assumption is valid.What is the best way to handle this?
The text was updated successfully, but these errors were encountered: