Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "stdlib" Router #197

Open
marwan-at-work opened this issue Feb 12, 2019 · 1 comment
Open

Drop "stdlib" Router #197

marwan-at-work opened this issue Feb 12, 2019 · 1 comment

Comments

@marwan-at-work
Copy link
Contributor

marwan-at-work commented Feb 12, 2019

For both server/kit, and SimpleServer For server/kit, is there a reason for having a user be able to override the gorilla/mux Router? The only two reasons I can think of are:

  1. Performance reasons: but I imagine if a user cared about the performance delta between stdlib vs mux, then Gizmo is the wrong library to use in the first place.
  2. Different features/functionality: but we don't expose those functionalities to the end user anyway.

Unless I'm missing an obvious reason here, we should probs just go with gorilla/mux as the default router.

I know we can also let the user pass their own mux for server/kit, but in that case, they have any mux they wish so it's a bit unrelated to this issue.

Thanks!

@jprobinson
Copy link
Contributor

I'm fine with dropping stdlib and leaning purely on gorilla/mux. I think this just came from the "router wars" days. I shouldn't have accepted those PRs 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants