Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible improvements on Tank War solution #2

Open
ny83427 opened this issue Jan 24, 2019 · 0 comments
Open

Possible improvements on Tank War solution #2

ny83427 opened this issue Jan 24, 2019 · 0 comments

Comments

@ny83427
Copy link
Owner

ny83427 commented Jan 24, 2019

  • some flow control or game rule logic implementation are mixed in object draw method, which is not separated clearly and seems to add burden for maintenance
  • a better approach might be let game objects just care about render, but separate game rule assertion, it will make changes to both part much easier
  • introduce an abstract game object would be useful
  • there seems no need to introduce CopyOnWriteArrayList here, as this is not a concurrent scenario of multi-threading, no need to confuse students with such kind of heavy stuff at this time
  • tank move/fire and other logic is not very well organized, needs refactoring and reorganization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant