You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@rohany pointed out that, since we started using the Rust-based Legion profiler (and stopped doing the post-processing as part of running the launcher), the message printed out at the end, which is supposed to tell the user how to view the profile, is not actually copy-pasteable:
Profiles have been generated under /home/bryan/work/cunumeric, run legion_prof --view /home/bryan/work/cunumeric/legate_*.prof to view them
Because we don't "install" the legion_prof executable under $CONDA_PREFIX/bin, at least in editable mode, so legion_prof is not on the PATH. The user would need to dig through to find it in the build directory, in this case under /home/bryan/work/legate.core/_skbuild/linux-x86_64-3.10/cmake-build/_deps/legion-build/bin/legion_prof.
@bryevdv and I think our best strategy here is to install a script under $CONDA_PREFIX/bin that points to the legion_prof in the build directory (I assume in non-editable mode we would just copy legion_prof itself), similar to what we do for things like legate, legate-jupyter and legate-create-library (see #669). Then we could keep the simple message, and have it be copy-pasteable.
@rohany pointed out that, since we started using the Rust-based Legion profiler (and stopped doing the post-processing as part of running the launcher), the message printed out at the end, which is supposed to tell the user how to view the profile, is not actually copy-pasteable:
Because we don't "install" the
legion_prof
executable under$CONDA_PREFIX/bin
, at least in editable mode, solegion_prof
is not on thePATH
. The user would need to dig through to find it in the build directory, in this case under/home/bryan/work/legate.core/_skbuild/linux-x86_64-3.10/cmake-build/_deps/legion-build/bin/legion_prof
.@bryevdv and I think our best strategy here is to install a script under
$CONDA_PREFIX/bin
that points to thelegion_prof
in the build directory (I assume in non-editable mode we would just copylegion_prof
itself), similar to what we do for things likelegate
,legate-jupyter
andlegate-create-library
(see #669). Then we could keep the simple message, and have it be copy-pasteable.@jjwilke @trxcllnt thoughts?
The text was updated successfully, but these errors were encountered: