Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure profiler view command is copy-pasteable #773

Open
manopapad opened this issue Jun 26, 2023 · 0 comments
Open

Make sure profiler view command is copy-pasteable #773

manopapad opened this issue Jun 26, 2023 · 0 comments
Labels
category:bug-fix PR is a bug fix and will be classified as such in release notes

Comments

@manopapad
Copy link
Contributor

@rohany pointed out that, since we started using the Rust-based Legion profiler (and stopped doing the post-processing as part of running the launcher), the message printed out at the end, which is supposed to tell the user how to view the profile, is not actually copy-pasteable:

Profiles have been generated under /home/bryan/work/cunumeric, run legion_prof --view /home/bryan/work/cunumeric/legate_*.prof to view them

Because we don't "install" the legion_prof executable under $CONDA_PREFIX/bin, at least in editable mode, so legion_prof is not on the PATH. The user would need to dig through to find it in the build directory, in this case under /home/bryan/work/legate.core/_skbuild/linux-x86_64-3.10/cmake-build/_deps/legion-build/bin/legion_prof.

@bryevdv and I think our best strategy here is to install a script under $CONDA_PREFIX/bin that points to the legion_prof in the build directory (I assume in non-editable mode we would just copy legion_prof itself), similar to what we do for things like legate, legate-jupyter and legate-create-library (see #669). Then we could keep the simple message, and have it be copy-pasteable.

@jjwilke @trxcllnt thoughts?

@manopapad manopapad added the category:bug-fix PR is a bug fix and will be classified as such in release notes label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug-fix PR is a bug fix and will be classified as such in release notes
Projects
None yet
Development

No branches or pull requests

1 participant