Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify repository config #25

Open
pi0 opened this issue Jun 22, 2022 · 2 comments
Open

Simplify repository config #25

pi0 opened this issue Jun 22, 2022 · 2 comments
Assignees

Comments

@pi0
Copy link

pi0 commented Jun 22, 2022

Instead of 3 separate options, { owner: 'nuxt', repo: 'image', branch: 'main' } we could support repository: 'nuxt/image#main'

@Tahul Tahul self-assigned this Nov 27, 2022
Copy link
Contributor

Tahul commented Nov 27, 2022

Taking this up for next versions;

Any preferred way to parse that string @pi0? Maybe we could support both syntaxes?

@pi0
Copy link
Author

pi0 commented Nov 28, 2022

Supporting object syntax makes sense too. Personally, i use simplified repo: 'owner/name' for unjs packages and parse it when needed as most of the the times, the combination is consumed. Also instead of branch, we could call it ref (ref can be also a git tag or commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants