-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required Text #1
Comments
I can see a potential problem here, but i cannot reproduce this error. Contao: 4.13.30 / 5.2.2 (APP_ENV=dev) |
Hi Dennis, I can confirm this. Same error here. If no text is given, you will run into an error. hero-element/src/Content/Hero.php Line 95 in 90cb0a6
Contao: 5.3 |
add container only when headline or text is given, closes #1
Update: problem found an solved in 1.2.2. You both set a Please test Version 1.2.2 and give feddback. |
If you set only a background image, an error occurs because a text is expected.
https://github.com/nutshell-framework/hero-element/blob/develop/src/Content/Hero.php#L95
Either you would make the text field mandatory or rule in the code if no text is sent.
The text was updated successfully, but these errors were encountered: