Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript compatibility checklist #529

Closed
6 tasks done
cainlevy opened this issue Jul 16, 2020 · 5 comments
Closed
6 tasks done

TypeScript compatibility checklist #529

cainlevy opened this issue Jul 16, 2020 · 5 comments
Labels
chores 🧹 Infrastructure and updates

Comments

@cainlevy
Copy link

cainlevy commented Jul 16, 2020

I've opened a couple of issues from attempting to use Semiotic v2 in TypeScript, then belatedly realized there may be enough to warrant a single thread and spare you the spam.

I'd be happy to contribute towards this progress. Semiotic's approach to data visualization resonates with me, but I'm having trouble getting started with these issues.

@emeeks
Copy link
Member

emeeks commented Jul 30, 2020

Sorry for the hassle but I really appreciate you systematically hitting it like this. I'll try to resolve these.

@emeeks
Copy link
Member

emeeks commented Aug 1, 2020

Take a look at rc6 and tell me how that works for you. I got rid of a lot of the anys and I think I got responsive frame types working and modified the tsconfig entry point to point at lib instead of dist, so I think we're in much better shape but would love to hear what's still missing.

@emeeks
Copy link
Member

emeeks commented Aug 4, 2020

Okay, rc6 had a bit of a mess to it, try rc7 it seems much more stable.

@willingc willingc added the chores 🧹 Infrastructure and updates label Dec 16, 2021
@willingc
Copy link
Member

Looks like this file resurfaced earlier this year: https://github.com/nteract/semiotic/blob/main/src/components/types/ordinalTypes.ts

@willingc
Copy link
Member

Closing this and tracking last action item in issue #576.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chores 🧹 Infrastructure and updates
Projects
None yet
Development

No branches or pull requests

3 participants