Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shake to give feedback #39

Open
chriscombs opened this issue Dec 11, 2019 · 1 comment
Open

Shake to give feedback #39

chriscombs opened this issue Dec 11, 2019 · 1 comment
Labels
enhancement New feature or request iOS

Comments

@chriscombs
Copy link
Contributor

The feedback feature needs to be implemented. The DOT project implemented it manually, but it should be added as a feature to the SDK.

Users should be able to shake the phone to display a dialogue that allows them to enter feedback, which is then sent to the backend.

We should be able to disable this after the first prompt, in case the user doesn't want to send feedback.

@chriscombs chriscombs added the enhancement New feature or request label Dec 11, 2019
@chriscombs
Copy link
Contributor Author

chriscombs commented Jan 6, 2020

To be added:

FeedbackManager, similar to ContentManager and ValidationManager etc. Ideally this would be a public protocol named FeedbackManager, with an internal class that conforms to it (similar to how we do Dependencies in our apps):

public protocol FeedbackManager { }
internal class APIFeedbackManager: FeedbackManager { }

And in NStack.swift:
public fileprivate(set) var feedbackManager: FeedbackManager?

in the start() function:
feedbackManager = APIFeedbackManager(repository: repository)

This manager needs to be able to send feedback to the NStack API. This API call is already done in the DOT app, so it can mostly be copied from there. The API call should go into the Repository as a FeedbackRepository protocol (similar to the others).

From the Feedback manager, we should be able to send feedback manually by programmatically calling a sendFeedback function or something like that. Part 2 will be to also be able to shake the device to send feedback. This may interfere with the shake to edit translations feature, so we will need to come up with a solution for deciding which feature to use when shaking the device.

@johsoe johsoe added the iOS label Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iOS
Projects
None yet
Development

No branches or pull requests

2 participants