Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status update #58

Closed
opoudjis opened this issue Dec 19, 2022 · 9 comments
Closed

Status update #58

opoudjis opened this issue Dec 19, 2022 · 9 comments
Assignees

Comments

@opoudjis
Copy link
Member

As of 19:00, 2022-12-19:

Now validating correctly.

Status as of right now:

1794 errors, 19468 warnings

Commenting out all Goessner examples:

\r(\s+)(create|update)Goessner:\r
\r#\1\2Goessner:\r#

1794 errors, 5682 warnings

Errors:

Warnings:

Excluding Goessner examples, which generate a lot of undetected errors

Other, include #40, #53

  • Warning info-license rule :: Info object should contain license field.: 1
  • Warning no-unused-components rule :: Component: "schemaDefinitions" is never used.: 1
  • Warning no-unused-components rule :: Component: "responsePayloads" is never used.: 1
  • Warning no-unused-components rule :: Component: "requestPayloads" is never used.: 1
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: Activity property must have required property 'EvaluationType'.: 2
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: AggregateStatisticInfo property must have required property 'Type'.: 2
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: PersonPicture property must have required property 'Type'.: 2
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: BilledEntity property type must be string.: 3
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: OtherLEA property type must be string.: 3
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'EvaluationType'.: 3
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: Location property type must be string.: 3
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must NOT have unevaluated properties {Data Model}.: 4
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: IdentityAssertions property must have required property 'SchemaName'.: 5
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: ActivityTime property must have required property 'Units'.: 5
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'Type'.: 6
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: CalculationRule property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: PersonRefId property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: InvoicedEntity property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: ParentObjectRefId property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: IdentityAssertion property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: Duration property type must be integer.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: ManagingSchool property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: ResourceRefId property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property type must be string.: 11
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: code property type must be integer.: 13
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: LocationRefId property type must be string.: 16
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: SIF_RefId property type must be string.: 16
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: {Data Model} property must NOT have unevaluated properties {Data Model}.: 20
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: OtherCodeList property must have required property 'Codeset'.: 45
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'SIF_RefObject'.: 60
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: OtherCode property type must be string.: 75
  • Warning XML misvalidation :: : 122
  • Example validation errored: required value must be ["array"]: Examples not generating arrays for Object Containers #38: 126
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: must NOT have unevaluated properties {Data Model}.: 141
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: {Infrastructure} property must NOT have unevaluated properties {Infrastructure}.: 143
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: must NOT have unevaluated properties {Infrastructure}.: 145
@opoudjis opoudjis self-assigned this Dec 19, 2022
@opoudjis
Copy link
Member Author

opoudjis commented Dec 19, 2022

11:30 PM, 2022-12-19

1790 errors, 30728 warnings

Errors:

Warnings:

Excluding Goessner examples, which generate a lot of undetected errors

Other, include #40, #53

  • Warning no-unused-components rule :: Component: "schemaDefinitions" is never used.: 1
  • Warning no-unused-components rule :: Component: "responsePayloads" is never used.: 1
  • Warning no-unused-components rule :: Component: "requestPayloads" is never used.: 1
  • Warning info-license rule :: Info object should contain license field.: 1
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: LearningResource property must have required property 'ReferenceType'.: 2
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: PersonPicture property must have required property 'Type'.: 2
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: AggregateStatisticInfo property must have required property 'Type'.: 2
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: Activity property must have required property 'EvaluationType'.: 2
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'ReferenceType'.: 3
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'EvaluationType'.: 3
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must NOT have unevaluated properties {Data Model}.: 4
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: IdentityAssertions property must have required property 'SchemaName'.: 5
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: DepartureSchool property must have required property 'City'.: 5
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: ActivityTime property must have required property 'Units'.: 5
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'Type'.: 6
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: ParentObjectRefId property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: CalculationRule property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: IdentityAssertion property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: ManagingSchool property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: Location property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: OtherLEA property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: BilledEntity property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: InvoicedEntity property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: ResourceRefId property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: PersonRefId property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: Duration property type must be integer.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'City'.: 10
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: code property type must be integer.: 13
  • Warning XML misvalidation :: : 14
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: DomainScore property must have required property 'PlausibleScaledValueList'.: 15
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: DomainScore property must have required property 'ScaledScoreStandardError'.: 15
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: DomainScore property must have required property 'ScaledScoreLogitValue'.: 15
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: DomainScore property must have required property 'ScaledScoreLogitStandardError'.: 15
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: DomainScore property must have required property 'RawScore'.: 15
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property type must be string.: 16
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: SIF_RefId property type must be string.: 16
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: LocationRefId property type must be string.: 16
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: {Data Model} property must NOT have unevaluated properties {Data Model}.: 20
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: OtherCodeList property must have required property 'Codeset'.: 50
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'SIF_RefObject'.: 75
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: OtherCode property type must be string.: 80
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: must NOT have unevaluated properties {Data Model}.: 158
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: {Infrastructure} property must NOT have unevaluated properties {Infrastructure}.: 161
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: must NOT have unevaluated properties {Infrastructure}.: 163

@opoudjis
Copy link
Member Author

Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: DomainScore property must have required property 'PlausibleScaledValueList'.: 15
Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: DomainScore property must have required property 'ScaledScoreStandardError'.: 15
Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: DomainScore property must have required property 'ScaledScoreLogitValue'.: 15
Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: DomainScore property must have required property 'ScaledScoreLogitStandardError'.: 15
Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: DomainScore property must have required property 'RawScore'.: 15

Have fixed in source

@opoudjis
Copy link
Member Author

10:00 PM, 2022-12-20

1790 1761 errors, 30728 24499 warnings

Errors:

Warnings:

Excluding Goessner examples, which generate a lot of undetected errors

Others which are almost all #40

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: PersonPicture property must have required property 'Type'.: 2
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: LearningResource property must have required property 'ReferenceType'.: 2
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: Activity property must have required property 'EvaluationType'.: 2
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property type must be object.: 2
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: AggregateStatisticInfo property must have required property 'Type'.: 2
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'EvaluationType'.: 3
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'ReferenceType'.: 3
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must NOT have unevaluated properties {Data Model}.: 4
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: {Data Model} property must NOT have unevaluated properties {Data Model}.: 4
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: ActivityTime property must have required property 'Units'.: 5
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: IdentityAssertions property must have required property 'SchemaName'.: 5
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: DepartureSchool property must have required property 'City'.: 5
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'Type'.: 6
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: Location property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: PictureSource property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: Duration property type must be integer.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: CalculationRule property type must be string.: 8
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'City'.: 10
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: code property type must be integer.: 13
  • Warning XML misvalidation :: : 14
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: PersonRefId property type must be string.: 16
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: OtherLEA property type must be string.: 16
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: ParentObjectRefId property type must be string.: 16
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: ManagingSchool property type must be string.: 16
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: ResourceRefId property type must be string.: 16
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: InvoicedEntity property type must be string.: 16
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: BilledEntity property type must be string.: 16
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: LocationRefId property type must be string.: 32
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: SIF_RefId property type must be string.: 32
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: must NOT have unevaluated properties {Data Model}.: 34
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: OtherCodeList property must have required property 'Codeset'.: 50
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'SIF_RefObject'.: 65
  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: {Infrastructure} property must NOT have unevaluated properties {Infrastructure}.: 161

@opoudjis
Copy link
Member Author

11:30 PM, 2022-12-21

1763 errors, 24119 warnings

The remaining issues are:

Errors:

Warnings:

  • Warning Goessner misvalidation: Do not validate Goessner examples in OpenAPI #47: 23214 23234

  • Warning XML misvalidation :: Distinct treatment of lists in XML as well as Goessner #56 : 14

  • Example value must conform to the schema: must match exactly one schema in oneOf: (Allow collection objects in top-level enum of objects #59): 163 489

  • Warning info-license rule :: Info object should contain license field.: 1

  • Warning no-unused-components rule :: Component: "requestPayloads" is never used.: 1

  • Warning no-unused-components rule :: Component: "responsePayloads" is never used.: 1

  • Warning no-unused-components rule :: Component: "schemaDefinitions" is never used.: 1

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property type must be object.: 2

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must NOT have unevaluated properties {Data Model}.: 4 xml:lang attribute in example object root is being ignored, don't worry about it

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: {Data Model} property must NOT have unevaluated properties {Data Model}.: 4 xml:lang attribute in example object root is being ignored, don't worry about it

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: must NOT have unevaluated properties {Data Model}.: 5 Allow collection objects in top-level enum of objects #59

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property must have required property 'City'.: 10 I have already fixed that in source, no idea why it's still showing up

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: code property type must be integer.: 13 Points to validation errors with infrastructure examples

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property type must be string.: 16 Points to validation errors with infrastructure examples, I think

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: {Infrastructure} property must NOT have unevaluated properties {Infrastructure}.: 161 Points to validation errors with infrastructure examples

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: must NOT have unevaluated properties {Infrastructure}.: 163 Points to validation errors with infrastructure examples

@opoudjis
Copy link
Member Author

opoudjis commented Jan 16, 2023

17:30, 2023-01-16

1763 1760 errors, 24119 24074 warnings

The remaining issues are:

Errors:

Warnings:

  • Warning Goessner misvalidation: Do not validate Goessner examples in OpenAPI #47: 23234

  • Warning XML misvalidation :: Distinct treatment of lists in XML as well as Goessner #56 : 14

  • Example value must conform to the schema: must match exactly one schema in oneOf: (Allow collection objects in top-level enum of objects #59): 484

  • Warning no-unused-components rule :: Component: "requestPayloads" is never used.: 1

  • Warning no-unused-components rule :: Component: "responsePayloads" is never used.: 1

  • Warning no-unused-components rule :: Component: "schemaDefinitions" is never used.: 1

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property type must be object.: 2

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: code property type must be integer.: 13 Points to validation errors with infrastructure examples

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property type must be string.: 16 Turned out to be another instance of Problems with GUID ~ RefID validation #48

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: {Infrastructure} property must NOT have unevaluated properties {Infrastructure}.: 161 Points to validation errors with infrastructure examples

  • Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: must NOT have unevaluated properties {Infrastructure}.: 163 Points to validation errors with infrastructure examples

@opoudjis
Copy link
Member Author

12:30, 2023-01-19

I have segregated OpenAPI 3.0 from OpenAPI 3.1 output, and omitted Goessner and XML examples from the former, in accordance with #39

1760 errors, 24074 554 warnings

Same Errors.

Warnings:

Warning no-unused-components rule :: Component: "schemaDefinitions" is never used.: 1
Warning no-unused-components rule :: Component: "responsePayloads" is never used.: 1
Warning no-unused-components rule :: Component: "requestPayloads" is never used.: 1
Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: `` property type must be object.: 2
Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: code property type must be integer.: 13
Warning XML misvalidation :: : 14
Warning Goessner misvalidation :: : 34
Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: {Infrastructure} property must NOT have unevaluated properties {Infrastructure}.: 161
Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: must NOT have unevaluated properties {Infrastructure}.: 163
Warning no-invalid-media-type-examples rule :: Example value must conform to the schema: must match exactly one schema in oneOf.: 164 (#59)

The remaining XML and Goessner examples are in the SIF infrastructure content, which is currently hard-coded, but which I am about to try to regenerate dynamically, omitting the Goessner/XML references for OpenAPI 3.0.

@opoudjis
Copy link
Member Author

19:00, 2023-01-23

1760 errors, 554 3 warnings

Warning no-unused-components rule :: Component: "requestPayloads" is never used.: 1
Warning no-unused-components rule :: Component: "responsePayloads" is never used.: 1
Warning no-unused-components rule :: Component: "schemaDefinitions" is never used.: 1
Error security-defined rule :: Every operation should have security defined on it or on the root level.: 800
Error spec rule :: Property create/updateObject is not expected here.: 960

Warning no-unused-components rule :: Component: "requestPayloads" is never used.: 1
Warning no-unused-components rule :: Component: "responsePayloads" is never used.: 1
Warning no-unused-components rule :: Component: "schemaDefinitions" is never used.: 1
Error security-defined rule :: Every operation should have security defined on it or on the root level.: 800
Error spec rule :: Property create/updateObject is not expected here.: 960

@opoudjis
Copy link
Member Author

18:15, 2023-01-24

validating OpenAPI3.0_AU.yaml...
OpenAPI3.0_AU.yaml: validated in 5496ms

Woohoo! Your OpenAPI definition is valid. 🎉

Zero errors. Zero warnings.

@4pins
Copy link
Collaborator

4pins commented Jan 24, 2023

@opoudjis Wow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants