Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QcaaNapoItems: revert fix to include substitute items, putting it bac… #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

QcaaNapoItems: revert fix to include substitute items, putting it bac… #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/nrt/config/QcaaNapoItems.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ outputFileName = "./out/system_reports/qcaa_napo_items.csv"
[[fields]]
"REF_ID" = "NAPTestItem.RefId"
[[fields]]
"TEST_ID" = "CalculatedFields.NAPTestRefId"
"TEST_ID" = "CalculatedFields.NAPTestLocalId"
[[fields]]
"ITEM_ID" = "NAPTestItem.TestItemContent.NAPTestItemLocalId"
[[fields]]
Expand Down
8 changes: 2 additions & 6 deletions reports/qcaaNapoItems.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ type QcaaNapoItems struct {
baseReport // embed common setup capability
}

//
// Detailed breakdown of each TestITem
//
func QcaaNapoItemsReport() *QcaaNapoItems {

r := QcaaNapoItems{}
Expand All @@ -24,13 +22,11 @@ func QcaaNapoItemsReport() *QcaaNapoItems {

}

//
// implement the EventPipe interface, core work of the
// report engine.
//
func (r *QcaaNapoItems) ProcessObjectRecords(in chan *records.ObjectRecord) chan *records.ObjectRecord {
func (r *QcaaNapoItems) ProcessCodeframeRecords(in chan *records.CodeframeRecord) chan *records.CodeframeRecord {

out := make(chan *records.ObjectRecord)
out := make(chan *records.CodeframeRecord)
go func() {
defer close(out)
// open the csv file writer, and set the header
Expand Down
2 changes: 1 addition & 1 deletion stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ func (tr *Transformer) simpleObjectReports() error {
reports.SystemObjectsCountReport(),
reports.QcaaNapoSchoolsReport(),
reports.QcaaNapoStudentsReport(),
reports.QcaaNapoItemsReport(),
reports.NswItemDescriptorsReport(),
reports.QcaaTestScoreSummaryReport(),
reports.SystemSchoolsReport(),
Expand Down Expand Up @@ -327,6 +326,7 @@ func (tr *Transformer) codeframeReports() error {
//
// reports
//
reports.QcaaNapoItemsReport(),
reports.QcaaNapoTestsReport(),
reports.QcaaNapoTestletItemsReport(),
reports.SystemCodeframeReport(tr.helper),
Expand Down