Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress bar #28

Open
jesteria opened this issue Dec 10, 2020 · 4 comments
Open

progress bar #28

jesteria opened this issue Dec 10, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@jesteria
Copy link
Collaborator

No description provided.

@jesteria jesteria added enhancement New feature or request question Further information is requested labels Dec 10, 2020
@JordanHolland
Copy link
Collaborator

An option that i'm aware of is tqdm. Any other ideas?

@jesteria jesteria removed the question Further information is requested label Jan 13, 2021
@jesteria
Copy link
Collaborator Author

I think tqdm is probably the best bet.

I also see for example the library progress; but, tqdm looks more complete to me.

(If need be we could also certainly write our own.)

I think the biggest issue is that I'm not aware of libraries that control stdout in such a way that you can freely write to it without conflict with the progress bar. So, for example, tqdm recommends monkey-patching sys.stdout to itself. Not at all a big deal, but worth considering. (And, we might want to clean up what we output, more generally, first.)

Beyond that, we could get a simple integration out the door pretty easily, since the nprintML runner iterates over pipeline steps.

An improvement could be integrating the progress bar more deeply, such that steps can produce smaller increments as they progress – this would be most useful (and easiest) within PCAP ingestion – but, that's not so immediately necessary.

@JordanHolland
Copy link
Collaborator

tqdm is probably our best bet as it can slot in to a process pool without any code. I'm mostly convinced we just want a progress bar when we're actually running nPrint (i.e. 5/500 files being processed) and not the entire pipeline. We have no real access to the progress of AutoML beyond its own output.

@jesteria
Copy link
Collaborator Author

jesteria commented Mar 15, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants