Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all custom text turn into "Loading" with courier, when incorrect or loading #156

Open
DanielJWood opened this issue May 8, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request Priority: Normal

Comments

@DanielJWood
Copy link
Contributor

Here's what it would look like.

image
DanielJWood added a commit that referenced this issue May 8, 2024
@DanielJWood DanielJWood self-assigned this May 8, 2024
@DanielJWood
Copy link
Contributor Author

DanielJWood commented May 8, 2024

@alykat review how this is working and if you're happy with it, close.

I am separately making a ticket (#157) to see if we can simply make the text load faster to prevent this.

@alykat
Copy link
Member

alykat commented May 8, 2024

I think this works, but yes, would definitely prefer to minimize the time this is visible.

Another approach could be to replace the whole text block with one Loading... message, rather than have so many?

I don't feel strongly either way.

@DanielJWood
Copy link
Contributor Author

Yeah making the whole thing say "Loading..." would definitely be better...I will leave open and backlog as a maybe

@DanielJWood DanielJWood added the enhancement New feature or request label May 8, 2024
@alykat alykat removed this from the Y - Pre-launch (week of May 6) milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority: Normal
Projects
None yet
Development

No branches or pull requests

2 participants