Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test shiny tidy up #750

Open
3 of 7 tasks
nikolai-b opened this issue Jun 30, 2019 · 7 comments
Open
3 of 7 tasks

Test shiny tidy up #750

nikolai-b opened this issue Jun 30, 2019 · 7 comments

Comments

@nikolai-b
Copy link
Contributor

nikolai-b commented Jun 30, 2019

We have a lot of apps running on the test server. Can we confirm they are all needed? Fine if they are I was just a bit surprised how many!

  • geostat
  • ict and ict-regional (I know about these but I don't know why there are two, are they both needed? https://github.com/ITHIM/ICT)
  • /meta-analyses/pa/diabetes, /meta-analyses/shiny/ and /meta-analyses/ (only /meta-analyses/shiny/ code works on the test server)
  • /test (doesn't seem to work...)
  • /pct-shiny-all-layers/
  • /schools (I'm guessing this isn't needed now as we have included this)
  • /nearmkt (same as schools, I'm guessing this isn't needed now)
@AnnaGoodman1
Copy link
Contributor

agree schools and nearmkt can be deleted. no definite knowledge of the others. thanks @nikolai-b

@Robinlovelace
Copy link
Member

geostat can go. Was for this, which ended up winning the vis competition, I think: http://rstudio-pubs-static.s3.amazonaws.com/102391_8eeb5ed0dfd24ec798b37434a243f6dc.html

@usr110
Copy link
Member

usr110 commented Jul 10, 2019

Thanks @nikolai-b for looking into it.
I think we need to keep both ict (England) and ict-regional, as it helps compare the two from time to time. Although England as a whole is already part of the ict-regional, but there are subtle differences in the scenarios.

Re meta-analysis, I think we need to keep all of them as well.

Re pct-shiny-all-layers, I am not sure we need it.

@Robinlovelace
Copy link
Member

Has this tidy-up been done @nikolai-b ? I suspect we can close this in 2020.

@nikolai-b
Copy link
Contributor Author

@Robinlovelace
Copy link
Member

👍

@AnnaGoodman1
Copy link
Contributor

AnnaGoodman1 commented Jul 26, 2020

none to do with me, @usr110 is the one to comment on the meta-analyses urls. If Ali happy with them going I am too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants