Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(root): update imports to use 'type' keyword for TypeScript consistency #7111

Closed
wants to merge 10 commits into from

Conversation

merrcury
Copy link
Member

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit c8c3137
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/6746c2ae0dd55b000862d15b
😎 Deploy Preview https://deploy-preview-7111.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SokratisVidros
Copy link
Contributor

@merrcury, which tool did we use to do this? We should add it as a pre-save or pre-commit hook so that the codebase remains consistent.

@merrcury
Copy link
Member Author

@merrcury, which tool did we use to do this? We should add it as a pre-save or pre-commit hook so that the codebase remains consistent.

I used pnpm lint --fix

@merrcury
Copy link
Member Author

But sometimes it does give issues with ENUM and all

@SokratisVidros
Copy link
Contributor

@merrcury feel free to merge this.

@merrcury
Copy link
Member Author

Opening a new one for this. This require lot of rebasing

@merrcury merrcury closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants