From a15d24c5f40292eb9c55ecbf1ad9d27abc1af92e Mon Sep 17 00:00:00 2001 From: Pawan Jain Date: Fri, 19 Apr 2024 17:10:54 +0530 Subject: [PATCH 1/3] feat: add google analytics script tag --- apps/web/public/index.html | 37 +++++++++++++++++++++++++++++++++---- 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/apps/web/public/index.html b/apps/web/public/index.html index 091c268d547..40b26f0dc74 100644 --- a/apps/web/public/index.html +++ b/apps/web/public/index.html @@ -26,6 +26,20 @@ --> Novu Manage Platform + + + @@ -37,12 +51,27 @@ async="async" type="text/javascript" > - <% } %> - - <% if ( process.env.REACT_APP_HUBSPOT_EMBED ) { %> + <% } %> <% if ( process.env.REACT_APP_HUBSPOT_EMBED ) { %> - + <% } %> + + + + From 87791ef0a83e627a44d115fa1c23a88b7bc47b39 Mon Sep 17 00:00:00 2001 From: Pawan Jain Date: Mon, 22 Apr 2024 14:14:29 +0530 Subject: [PATCH 2/3] fix: add conditions and environment variables --- apps/web/.env | 1 + apps/web/public/index.html | 53 ++++++++++++++++++++------------------ 2 files changed, 29 insertions(+), 25 deletions(-) diff --git a/apps/web/.env b/apps/web/.env index 21c9c6651ff..1f0ca564ab2 100644 --- a/apps/web/.env +++ b/apps/web/.env @@ -16,3 +16,4 @@ REACT_APP_LAUNCH_DARKLY_CLIENT_SIDE_ID= IS_TEMPLATE_STORE_ENABLED= IS_MULTI_PROVIDER_CONFIGURATION_ENABLED= IS_MULTI_TENANCY_ENABLED= +REACT_APP_NOVU_GTM_ID= diff --git a/apps/web/public/index.html b/apps/web/public/index.html index 40b26f0dc74..8e642660f4c 100644 --- a/apps/web/public/index.html +++ b/apps/web/public/index.html @@ -1,6 +1,22 @@ + + <% if ( process.env.REACT_APP_NOVU_GTM_ID ) { %> + + <% } %> + @@ -26,22 +42,20 @@ --> Novu Manage Platform - - - + + <% if ( process.env.REACT_APP_NOVU_GTM_ID ) { %> + + <% } %> +
<% if ( process.env.REACT_APP_DOCKER_HOSTED_ENV === 'false' ) { %> @@ -62,16 +76,5 @@ > <% } %> - - - - From d8923033f3a272349c591ed0b61128990b419540 Mon Sep 17 00:00:00 2001 From: Pawan Jain Date: Wed, 24 Apr 2024 17:09:31 +0530 Subject: [PATCH 3/3] fix: add react app gtm id in reusable web deploy yml --- .github/workflows/reusable-web-deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reusable-web-deploy.yml b/.github/workflows/reusable-web-deploy.yml index 888906834e5..99bffdf3556 100644 --- a/.github/workflows/reusable-web-deploy.yml +++ b/.github/workflows/reusable-web-deploy.yml @@ -86,7 +86,7 @@ jobs: echo REACT_APP_LAUNCH_DARKLY_CLIENT_SIDE_ID=${{ secrets.LAUNCH_DARKLY_CLIENT_SIDE_ID }} >> .env echo REACT_APP_HUBSPOT_EMBED=${{ inputs.react_app_hubspot_embed }} >> .env echo REACT_APP_STRIPE_CLIENT_KEY=${{ secrets.STRIPE_CLIENT_KEY }} >> .env - + echo REACT_APP_NOVU_GTM_ID=${{ secrets.REACT_APP_NOVU_GTM_ID }} >> .env - name: Envsetup working-directory: apps/web run: npm run envsetup