Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: @novu/framework support for commonjs modules #6701

Closed
2 tasks done
paulwer opened this issue Oct 16, 2024 · 2 comments · Fixed by #6766 or #6963
Closed
2 tasks done

🚀 Feature: @novu/framework support for commonjs modules #6701

paulwer opened this issue Oct 16, 2024 · 2 comments · Fixed by #6766 or #6963
Labels

Comments

@paulwer
Copy link
Contributor

paulwer commented Oct 16, 2024

🔖 Feature description

Add .cjs modules into the build of the packages.

🎤 Why is this feature needed ?

Currently the packages are not supporting commonjs, which is still widly used.

✌️ How do you aim to achieve this?

f.ex. https://stackoverflow.com/questions/74937600/how-to-support-es-modules-and-commonjs-modules-at-the-same-time

🔄️ Additional Information

maybe this would also be helpfull for other packages.

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

Copy link

linear bot commented Oct 16, 2024

@rifont
Copy link
Collaborator

rifont commented Nov 13, 2024

Resolved with the new release of @novu/framework@2.4.0 with both ESM+CJS bundled into build artifacts 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants