Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Cannot find module '@novu/framework/next' or its corresponding type declarations.ts #6332

Closed
2 tasks done
patbeqo opened this issue Aug 15, 2024 · 6 comments · Fixed by #6766 or #6963
Closed
2 tasks done
Assignees
Labels

Comments

@patbeqo
Copy link

patbeqo commented Aug 15, 2024

📜 Description

Cannot find module '@novu/framework/next' or its corresponding type declarations.ts

👟 Reproduction steps

import { serve } from "@novu/framework/next";

"@novu/framework": "2.0.0-canary.5"

👍 Expected behavior

Typescript support

👎 Actual Behavior with Screenshots

Unable to import from '@novu/framework/next'

Novu version

2.0.0-canary.5

npm version

10.5.0

node version

v18.20.1

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

@brunocamboim
Copy link

Did you find any solutions? I have the same problem, but with @novu/framework/express

@patbeqo
Copy link
Author

patbeqo commented Aug 28, 2024

@brunocamboim I've disabled the type checking for now...

// @ts-ignore
import { serve } from "@novu/framework/next";

@linear linear bot closed this as completed Sep 3, 2024
@rifont rifont reopened this Sep 23, 2024
@paulwer
Copy link
Contributor

paulwer commented Sep 23, 2024

dont know, if this is helpfull, but in our case this was related to using commonjs modules, so we used require as an workaround and it works with our setup of express.

Maybe a comminjs build of the lib would be suiteable.

@SokratisVidros
Copy link
Contributor

@patbeqo which Next.js version are you using? Can you please send us a small reproduction?

@rifont
Copy link
Collaborator

rifont commented Nov 13, 2024

Hey @patbeqo, we have just released @novu/framework@2.4.0 with both ESM+CJS bundled into build artifacts 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants