Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Tech Feature: Specify the tenant id as HTTP header #5741

Closed
2 tasks done
alexanderhofstaetter opened this issue Jun 15, 2024 · 1 comment
Closed
2 tasks done
Labels

Comments

@alexanderhofstaetter
Copy link

🔖 Feature description

we seperate our clients by different tenants, and use novu as a central notification plattform. We operate a reverse proxy before novu and we need to map and validate the requests to the corresponding tenants.

🎤 Why is this feature needed ?

We use a custom JWT based auth proxy and we need to verify that the auth client_id matches (or allows) the specific tenant_id.

We currently have to look into the request body which can get pretty annoying, especially

✌️ How do you aim to achieve this?

add a tenant_id header to api calls. when this header is present, no tenant data is allowed in the body and everything gets mapped to the specific tenant.

if the tenant is not present, the tenants get auto created only with the id (additional data can be added later - e.g. in the UI)

🔄️ Additional Information

validating and inspecting http request body is pretty hard

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

Copy link

linear bot commented Jun 15, 2024

@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant