Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Support SendGrid ASM parameters #5402

Closed
2 tasks done
dmgarland opened this issue Apr 12, 2024 · 2 comments
Closed
2 tasks done

🚀 Feature: Support SendGrid ASM parameters #5402

dmgarland opened this issue Apr 12, 2024 · 2 comments
Labels

Comments

@dmgarland
Copy link
Contributor

🔖 Feature description

ASM groups are a SendGrid feature designed to allow e-mail suppressions short of stopping all mail.

The SendGrid API supports asm as an option, where the group id is matched against the recipient to see whether they should be sent mail or not.

Currently the Novu SendGrid provider doesn't support asm parameters passed via customData. This patches that to allow an asm group id to be passed directly through to SendGrid

🎤 Why is this feature needed ?

We have a use case where an ASM group is shared with other parts of our platform that require to send mail, so we need to suppress mail being sent to members of that group.

✌️ How do you aim to achieve this?

I will change the SendGrid provider to allow the passing of this option

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

Yes I am willing to submit a PR!

Copy link

linear bot commented Apr 12, 2024

@Abobos
Copy link
Contributor

Abobos commented Jun 7, 2024

Can I work on this issue?

@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants