Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: UI/UX issue for updating changes in web UI, changes are not persisted if update button is not pressed #5032

Open
2 tasks done
lwuethrich-devedis opened this issue Dec 28, 2023 · 2 comments
Labels
Design debt Created by Linear-GitHub Sync Missing Designs Created by Linear-GitHub Sync @novu/web

Comments

@lwuethrich-devedis
Copy link

📜 Description

During any actions when updating workflows it is required that after changing templates, configuring channels or similar for a workflow that the 'Update' button is pressed otherwise the changes are not applied.

There is no feedback that this has to be done and when opening the workflow settings on the right the sidebar even covers the update button. This makes it highly probable by accident to not apply setting changes.

When changing pages it would be nice that a confirmation modal pops up that allows to save unsaved changes or discard them as well as some visual indicator that there are unsaved changes. In addition, moving the 'Update' button somewhere else that it is not covered by the sidebar would be an improvement as well.

I categorize this as bug and not polishing as this feels serious enough that it could lead to unwanted behavior.

👟 Reproduction steps

  1. Go to the workflows page
  2. Edit a workflow
  3. Leave without pressing the Update button
  4. Changes are not persisted

👍 Expected behavior

  • The web ui should ask for confirmation to save or discard changes when routing elsewhere
  • Moving the button so that it isn't covered by the right sidebar
  • Maybe a visual indicator for unsaved changes

👎 Actual Behavior with Screenshots

Bild 28 12 23 um 16 49

Novu version

Novu SaaS

npm version

No response

node version

No response

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

None

Copy link

linear bot commented Dec 28, 2023

NV-3332 🐛 Bug Report:

@lwuethrich-devedis lwuethrich-devedis changed the title 🐛 Bug Report: 🐛 Bug Report: UI/UX issue for updating changes in web ui, changes are not persisted if update button is not pressed Dec 28, 2023
@jainpawan21
Copy link
Member

@lwuethrich-devedis

Thanks for reporting this.
We will add a warning popup there.

@linear linear bot changed the title 🐛 Bug Report: UI/UX issue for updating changes in web ui, changes are not persisted if update button is not pressed 🐛 Bug Report: UI/UX issue for updating changes in web UI, changes are not persisted if update button is not pressed Jan 3, 2024
@linear linear bot added Missing Designs Created by Linear-GitHub Sync Design debt Created by Linear-GitHub Sync labels Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design debt Created by Linear-GitHub Sync Missing Designs Created by Linear-GitHub Sync @novu/web
Projects
None yet
Development

No branches or pull requests

2 participants