Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Digests with filter behave improperly #4957

Closed
2 tasks done
MasonD opened this issue Dec 8, 2023 · 2 comments · Fixed by #4992
Closed
2 tasks done

🐛 Bug Report: Digests with filter behave improperly #4957

MasonD opened this issue Dec 8, 2023 · 2 comments · Fixed by #4992
Assignees
Labels

Comments

@MasonD
Copy link
Contributor

MasonD commented Dec 8, 2023

📜 Description

When a digest has a filter attached and that filter succeeds, messages are sent immediately, resulting in one message per trigger with each message having a digest of the triggers leading up to it.

👟 Reproduction steps

This branch https://github.com/MasonD/novu/tree/digest-filter-failing-test has a failing test "should digest events within time interval with filter".

👍 Expected behavior

Digests behave identically to when they have no filter attached when they have a filter that passes. The test I wrote passes.

👎 Actual Behavior with Screenshots

The test I wrote fails. Digests send one message per trigger when they have a filter even when the filter passes.

Novu version

next (commit cf7ec7d)

npm version

8.11.0

node version

v16.15.1

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

@MasonD MasonD changed the title 🐛 Bug Report: 🐛 Bug Report: Digests with filter behave improperly Dec 8, 2023
@jainpawan21
Copy link
Member

@davidsoderberg

@ainouzgali
Copy link
Contributor

Hi @MasonD , thanks for reporting!! I pushed a fix into next, let me know if you still encounter problems :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants