Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-3237] Intercom chat bubble shouldn't be visible #4912

Closed
LetItRock opened this issue Nov 29, 2023 · 5 comments · Fixed by #4951
Closed

[NV-3237] Intercom chat bubble shouldn't be visible #4912

LetItRock opened this issue Nov 29, 2023 · 5 comments · Fixed by #4951
Assignees
Labels
bug Something isn't working good first issue Good for newcomers @novu/web

Comments

@LetItRock
Copy link
Contributor

Reproduction Steps

  1. Navigate to the Integrations page.
  2. Click on the existing integration from the list to edit.
  3. Close the Integration Sidebar.
  4. The Intercom chat bubble will appear after.

Expected Behaviour

  • the Intercom chat bubble won't show
  • the Intercom popover should be only controlled by the help button "?" from the header navigation

Additional info

For the local development, you would need to update the INTERCOM_APP_ID.

export const INTERCOM_APP_ID = window._env_.REACT_APP_INTERCOM_APP_ID || process.env.REACT_APP_INTERCOM_APP_ID;

Screenshots

image

Screen.Recording.2023-11-28.at.17.14.54.mov
@LetItRock LetItRock added bug Something isn't working good first issue Good for newcomers @novu/web labels Nov 29, 2023
@LetItRock LetItRock changed the title Intercom chat bubble shouldn't be visible [NV-3237] Intercom chat bubble shouldn't be visible Nov 29, 2023
@zt4ff
Copy link

zt4ff commented Nov 30, 2023

@LetItRock This is my time contributing to the project. Can you assign me to this please?

@LetItRock
Copy link
Contributor Author

@LetItRock This is my time contributing to the project. Can you assign me to this please?

of course @zt4ff! if anything needed let me know ;)

@Dharmavineta
Copy link

Hey, what's the status? Will be glad to work on the issue if it hasn't been resolved already.

@PaperBoardOfficial
Copy link
Contributor

@LetItRock I had been working on this issue. Kindly, assign to me.

Screen.Recording.2023-12-06.at.5.07.41.PM.mov

@PaperBoardOfficial
Copy link
Contributor

PaperBoardOfficial commented Dec 6, 2023

@LetItRock I have also raised a PR #4951,
Let me know if I can improve further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers @novu/web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants