-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NV-983] Create webhook parser for Mailgun (email) #4800
Comments
Cool, so let's make it clear cause it could be confusing - this one talks about both email and sms… |
@oba2311 that should be other issues 😄 |
Overall looking good! Maybe add some hints on where to start for inapp and for chat? |
Hi, I'm Jarvis 🤖%0A%0AI'm a bot built to help you with your contribution to Novu. %0AI will add instructions and guides on how to run the subset of the Novu platform associated to this issue and make your first contribution.%0A%0AThis issue was tagged as related to %0A %0A%0AFirst time contributing to Novu?%0A%0A If that's the first time you want to contribute to Novu here are a few simple steps to get you started:%0A 1. Fork the repository and clone your fork to your local machine.%0A 2. Install the dependencies usingnpm run setup:project .%0A 3. Create a new branch with the number of the issue, for example: 1454-fix-something-cool and start contributing based on the Contributing Guide or the short guide in the section below.%0A 4. Create a Pull request and follow the template of creation %0A%0A
Run and test %0A%0A ### Run API in watch mode%0A The easiest way to start the API is to run |
Why
To be able to give better answers why a message was not sent to a subscriber we need to get some info from the provider with a webhook. (deliverability status, rejection status etc).
How
To do this we need to implement these functions inside of the provider:
The
getMessageId
needs to return all identifiers that should be the same value as id that is returned fromsendMessage
with help of this we can connect a webhook to the specific message.parseEventBody
will get the full webhook body and the current identifier that the body should be parsed for. If there is nothing to parse the method should returnundefined
.All returns that is not
undefined
should be an object that is in this format:Note that statuses for email needs to be value from
EmailEventStatusEnum
and sms should have a status fromSmsEventStatusEnum.
Example of how to do it can be found in
SendgridEmailProvider
.From SyncLinear.com | NV-983
The text was updated successfully, but these errors were encountered: