Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-3053] Migrate from onesignal-node SDK to the official @onesignal/node-onesignal #4635

Closed
LetItRock opened this issue Oct 23, 2023 · 8 comments · Fixed by #4840
Closed
Assignees

Comments

@LetItRock
Copy link
Contributor

What?

In the @novu/one-signal package we would like to migrate from using the onesignal-node SDK to the official @onesignal/node-onesignal SDK. Check the documentation about the it here: https://github.com/OneSignal/onesignal-node-api#readme

Why? (Context)

Due to vulnerabilities and un-maintained SDK, we should move from using unofficial onesignal-node SDK.

Definition of Done

  • the onesignal-node SDK package has been replaced with @onesignal/node-onesignal
  • the current provider functionality works with the calls to the new @onesignal/node-onesignal SDK:
    • attachments
    • email delivery with all fields
@Dhoni77
Copy link
Contributor

Dhoni77 commented Oct 24, 2023

HI @LetItRock I would like to work on this.

@djabarovgeorge
Copy link
Contributor

Hey @Dhoni77 you are already assigned to an open issue. Let's see if someone is willing to help here, if not we will assign you.

@sakshivbp1812
Copy link

@Dhoni77 I would like to work on this issue

@anshikavashistha
Copy link

@LetItRock Can I work in this issue?

@djabarovgeorge
Copy link
Contributor

Hey @anshikavashistha,
This issue has already been assigned.
@sakshivbp1812 how is your progress, are you managing to create migration for onesignal?

@scopsy
Copy link
Contributor

scopsy commented Nov 6, 2023

@sakshivbp1812 how things are going? Please let me know if you would love to be un-assigned so we can let someone else to work on this in case you are not able to do so 🙏

@Dhoni77
Copy link
Contributor

Dhoni77 commented Nov 6, 2023

Hi @scopsy If there is no progress I can take this issue

@scopsy scopsy assigned Dhoni77 and unassigned sakshivbp1812 Nov 12, 2023
@scopsy
Copy link
Contributor

scopsy commented Nov 12, 2023

@Dhoni77 have assigned you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants