Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-3038] Migrate from @sendinblue/client SDK to direct API calls with Axios #4589

Closed
LetItRock opened this issue Oct 19, 2023 · 5 comments · Fixed by #4596
Closed

[NV-3038] Migrate from @sendinblue/client SDK to direct API calls with Axios #4589

LetItRock opened this issue Oct 19, 2023 · 5 comments · Fixed by #4596
Assignees

Comments

@LetItRock
Copy link
Contributor

What?

In the @novu/sendinblue package we would like to migrate from using the @sendinblue/client SDK to having a code that directly calls to the provider APIs. Check the documentation about the API here: https://developers.brevo.com/

Why? (Context)

Due to an un-maintained SDK, we should move from the official SDK' to working directly with the provider's API spec.

Definition of Done

  • the SDK package has been removed from the package.json file
  • the current provider functionality works with the calls to their APIs using Axios
    • attachments
    • email delivery with all fields
@Vidip-Ghosh
Copy link

Vidip-Ghosh commented Oct 19, 2023

Which tech will be used in this case?

@nick2432
Copy link
Contributor

can i work on this?

@Dhoni77
Copy link
Contributor

Dhoni77 commented Oct 20, 2023

I would like to work on this

@ayushshukla7777
Copy link
Contributor

hey, I'm free too. Can I work on this or any of the new tasks?

@djabarovgeorge
Copy link
Contributor

Thanks to everyone for taking the initiative to help 🙏, I will assign @Dhoni77 for now as no one was assigned yet and he raised a PR already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants