Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-3039] Migrate from sparkpost SDK to direct API calls with Axios #4588

Closed
LetItRock opened this issue Oct 19, 2023 · 7 comments · Fixed by #4785
Closed

[NV-3039] Migrate from sparkpost SDK to direct API calls with Axios #4588

LetItRock opened this issue Oct 19, 2023 · 7 comments · Fixed by #4785
Assignees

Comments

@LetItRock
Copy link
Contributor

LetItRock commented Oct 19, 2023

What?

In the @novu/sparkpost package we would like to migrate from using the sparkpost SDK to have a code that directly calls to the provider APIs. Check the documentation about the API here: https://developers.sparkpost.com/api/

Why? (Context)

Due to an un-maintained SDK, we should move from the official SDK' to working directly with the provider's API spec.

Definition of Done

  • the SDK package has been removed from the package.json file
  • the current provider functionality works with the calls to their APIs using Axios
    • attachments
    • email delivery with all fields
@michaldziuba03
Copy link
Contributor

@LetItRock can you assign me, I'm currently working on other issue regarding Sparkpost and I want to avoid git conflicts

@harshit-senpai
Copy link

Hey I would like to work on it

@sccalabr
Copy link

I would be willing to work on this

@djabarovgeorge
Copy link
Contributor

Hey @michaldziuba03,
We assigned you please let us know if you won't have the time to work on this issue so we can assign it if needed.

@ayushshukla7777
Copy link
Contributor

Hey @LetItRock @djabarovgeorge , Since no one is activly working on this issue, I would like to raise a PR.

@michaldziuba03
Copy link
Contributor

@ayushshukla7777 it's active

I'm waiting for merge: #3736

@ayushshukla7777
Copy link
Contributor

hey @michaldziuba03 , I though it was inactive, my bad. Since I already did this, I will just put it here. After that merge, it can be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants