Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Missing Sender Name in Mandrill (Email) Provider #4558

Closed
2 tasks done
emersonliuuu opened this issue Oct 17, 2023 · 2 comments · Fixed by #4568
Closed
2 tasks done

🐛 Bug Report: Missing Sender Name in Mandrill (Email) Provider #4558

emersonliuuu opened this issue Oct 17, 2023 · 2 comments · Fixed by #4568
Assignees
Labels

Comments

@emersonliuuu
Copy link
Contributor

📜 Description

Sender Name doesn't work in Mandrill Provider, as the current implementation is missing the from_name parameter required by Mandrill to set up the sender's name in the email.

👟 Reproduction steps

  1. Setup Mandrill provider in Novu Cloud
  2. Create a workflow and implement a email template with Mandrill provider
  3. Send a test email and check it in your inbox.
  4. You might find there's no sender name.

👍 Expected behavior

SenderName <[email protected]> is the expected value in the from field in received email

👎 Actual Behavior with Screenshots

Actually will only receive [email protected], although you have set up the Sender Name in Novu.

Novu version

0.20.0

npm version

No response

node version

No response

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

@krishanu7
Copy link

please assign me

@saikiran76
Copy link

Please assign me this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants