Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Node user instead of root user in Dockerfiles #4480

Open
2 tasks done
mictrax opened this issue Oct 10, 2023 · 4 comments
Open
2 tasks done

🐛 Bug Report: Node user instead of root user in Dockerfiles #4480

mictrax opened this issue Oct 10, 2023 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@mictrax
Copy link

mictrax commented Oct 10, 2023

📜 Description

For security reasons, it would be great to switch to the node user (1000) and grant the permissions instead of using the root user in the Dockerfiles (especially in the Dockerfile for the web container)

Set the permissions for the current folder to the node user and switch user at the end of the dockerfiles

RUN chown -R 1000:1000 .

USER 1000

👟 Reproduction steps

Build docker images

👍 Expected behavior

Node user (1000) should be used instead of root user

👎 Actual Behavior with Screenshots

Folder permissions are not set for node user

Novu version

0.19.0

npm version

No response

node version

No response

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

@mictrax
Copy link
Author

mictrax commented Oct 10, 2023

@scopsy scopsy added help wanted Extra attention is needed and removed triage labels Oct 10, 2023
@sivangbagri
Copy link

Hii I would like to work on this tissue .Please assign me this issue

@abhi-vardhan
Copy link

Hey, I can fix this if you can assign this to me

@mictrax
Copy link
Author

mictrax commented Oct 23, 2023

PR: #4623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants