Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-3014] Unexpected provider error in Nexmo sms provider #4468

Closed
jainpawan21 opened this issue Oct 9, 2023 · 15 comments
Closed

[NV-3014] Unexpected provider error in Nexmo sms provider #4468

jainpawan21 opened this issue Oct 9, 2023 · 15 comments
Assignees
Labels
Hacktoberfest help wanted Extra attention is needed

Comments

@jainpawan21
Copy link
Member

jainpawan21 commented Oct 9, 2023

What?

Nexmo SMS provider is giving Unexpected provider error with all numbers

Why? (Context)

Steps to reproduce:-

  1. Go to Nexmo (Vonage) SMS API dashboard
  2. Copy API Key, Api Secret and From address (id)
  3. Create new nexmo integration and add above credentials, make this integration active
  4. Create a workflow and add SMS step
  5. trigger the workflow with a valid SMS number (make sure you are using same number you signed up on nexmo if you are in the free tier), you will see an unexpected provider error in the activity feed log without any error description
    image
  6. Go back to Nexmo (Vonage) dashboard, copy the example curl code that they provide to send the SMS. Hit the curl, SMS will be send successfully

It means that there is some issue in our nexmo SDK implementation in novu

Definition of Done

Nexmo provider should work correctly and throw descriptive error in case of exception.

NV-3014

@jainpawan21 jainpawan21 changed the title Unexpected provider error in Nexmo sms provider [NV-3014] Unexpected provider error in Nexmo sms provider Oct 9, 2023
@jainpawan21 jainpawan21 added help wanted Extra attention is needed Hacktoberfest labels Oct 9, 2023
@biswajit287
Copy link

Hi @jainpawan21, I would like work on this issue. Can you please assign this to me. Thanks!

@parveshsaini
Copy link
Contributor

Hey @jainpawan21! I've worked with SMS providers and have a good idea how to deal with this. It'll be much appreciated if you could assign it to me

@parveshsaini
Copy link
Contributor

I've completed the issue assigned to me and have raised the PR as well. So now I'm available to work on another issue

@jainpawan21
Copy link
Member Author

@parveshsaini
Let @biswajit287 work on this issue.
I will assign you a new issue.
We are going to create few more issues in upcoming days.

@parveshsaini
Copy link
Contributor

Okay np. Good luck @biswajit287 😊

@nick2432
Copy link
Contributor

can i work on this issue?

@parveshsaini
Copy link
Contributor

Hey @jainpawan21 👋
The current assignee seems inactive. Can you please assign it to me?
The issue currently assigned to me requires test credentials which Zac will provide me in few days. In the meantime, I'd like to work on this issue.

@scopsy
Copy link
Contributor

scopsy commented Oct 16, 2023

Hi @biswajit287 any updates or help is needed ?

@ayushshukla7777
Copy link
Contributor

hey, Can I take this issue if current assignees is inactive

@parveshsaini
Copy link
Contributor

Hey 👋 @jainpawan21 @scopsy
I've figured out how to get this done. It'll be much appreciated if you could assign it to me.

@biswajit287
Copy link

biswajit287 commented Oct 19, 2023

Hi @biswajit287 any updates or help is needed ?

Hi @scopsy ,
I'm currently facing issues while trying to run the project on my system. Initially, it compiles successfully, but when I make code updates and save them, it fails to compile with an error message: The build failed because the process exited too early. This likely indicates a memory issue or a premature process termination (e.g., kill -9).`

image

I'm using the following system configuration:

RAM: 16GB
Processor: AMD Ryzen 5 5500U with Radeon Graphics
Environment: WSL (Windows Subsystem for Linux)
I'm looking for guidance on the minimum system requirements needed to set up and run the project smoothly.

@jainpawan21
Copy link
Member Author

@biswajit287 Could you please clean using npm run clean , delete all node_modules using npx npkill and please try again npm run setup:project
It should work

@sr-26
Copy link
Contributor

sr-26 commented Nov 7, 2023

@jainpawan21 This issue appears to be inactive. I would like to take on this task and work on it.

@PaperBoardOfficial
Copy link
Contributor

PaperBoardOfficial commented Dec 11, 2023

@jainpawan21 I think this issue can be closed because I checked the SMS is being sent successfully, given that one copies from, apiKey, apiSecret correctly from Vonage Dashboard.

Screenshot 2023-12-11 at 4 46 51 PM Screenshot 2023-12-11 at 4 46 51 PM

@jainpawan21
Copy link
Member Author

Thanks for the update @PaperBoardOfficial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants